From 24b293e45e44ed3fee5fee80af5cca2ba5f08854 Mon Sep 17 00:00:00 2001 From: Rajesh Taneja Date: Tue, 4 Mar 2014 15:55:50 +0800 Subject: [PATCH] MDL-41266 Logging: Added choose option for external database store --- admin/tool/log/store/database/classes/helper.php | 1 + admin/tool/log/store/database/classes/log/store.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/admin/tool/log/store/database/classes/helper.php b/admin/tool/log/store/database/classes/helper.php index 6c6f884a8fe..1acb99cdaf4 100644 --- a/admin/tool/log/store/database/classes/helper.php +++ b/admin/tool/log/store/database/classes/helper.php @@ -39,6 +39,7 @@ class helper { */ public static function get_drivers() { return array( + '' => get_string('choosedots'), 'native/mysqli' => \moodle_database::get_driver_instance('mysqli', 'native')->get_name(), 'native/mariadb' => \moodle_database::get_driver_instance('mariadb', 'native')->get_name(), 'native/pgsql' => \moodle_database::get_driver_instance('pgsql', 'native')->get_name(), diff --git a/admin/tool/log/store/database/classes/log/store.php b/admin/tool/log/store/database/classes/log/store.php index d484c7c3300..aad8c9295e7 100644 --- a/admin/tool/log/store/database/classes/log/store.php +++ b/admin/tool/log/store/database/classes/log/store.php @@ -70,7 +70,7 @@ class store implements \tool_log\log\writer, \core\log\sql_select_reader { } $dbdriver = $this->get_config('dbdriver'); - if (!$dbdriver) { + if (empty($dbdriver)) { $this->extdb = false; return false; }