L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-69231 behat: remaining work for role capability generator

Browse Source 
This commit does few things:
* Unify data generators usage to role short name.
* Replace remaining manual steps to use the new data generator.
* Also replaced other manual steps to set config to use data generators.
* Tidy up of some tests, aligning pipes and splitting one line steps into multiple lines.
* Fixes tests to have one Given/When/Then per scenario.
This commit is contained in:
Simey Lameze
2023-06-02 12:47:27 +08:00
parent aa2fc4048e
commit 2367bc9ff6
32 changed files with 127 additions and 171 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/feedback/tests/behat/anonymous.feature
+4 -4
View File
@@ -59,8 +59,8 @@ Feature: Anonymous feedback
@javascript
Scenario: Complete anonymous feedback and view analysis on the front page as an authenticated user
Given the following "role capability" exists:
| role | Authenticated user on frontpage |
| mod/feedback:viewanalysepage | Allow |
| role | frontpage |
| mod/feedback:viewanalysepage | allow |
And I log in as "user1"
And I am on site homepage
When I follow "Site feedback"
@@ -117,8 +117,8 @@ Feature: Anonymous feedback
Given the following config values are set as admin:
| feedback_allowfullanonymous | 1 |
And the following "role capability" exists:
| role | Guest |
| mod/feedback:viewanalysepage | Allow |
| role | guest |
| mod/feedback:viewanalysepage | allow |
When I follow "Site feedback"
And I should not see "Preview questions"
And I follow "Answer the questions"
mod/feedback/tests/behat/non_anonymous.feature
+2 -2
View File
@@ -55,8 +55,8 @@ Feature: Non anonymous feedback
@javascript
Scenario: Complete non anonymous feedback and view analysis on the front page as an authenticated user
Given the following "role capability" exists:
| role | Authenticated user on frontpage |
| mod/feedback:viewanalysepage | Allow |
| role | frontpage |
| mod/feedback:viewanalysepage | allow |
When I am on the "Site feedback" "feedback activity" page logged in as user1
And I follow "Answer the questions"
And I should see "Do you like our site?"