From 205409604144b191fd68dfb5fe23264678e6df4b Mon Sep 17 00:00:00 2001 From: tjhunt Date: Fri, 20 Jun 2008 16:30:35 +0000 Subject: [PATCH] MDL-15332 - Item analysis links to the question edit form even for users without an appropriate capability. --- mod/quiz/report/analysis/report.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/mod/quiz/report/analysis/report.php b/mod/quiz/report/analysis/report.php index cbd7f1f7d6a..d30ee3a513b 100644 --- a/mod/quiz/report/analysis/report.php +++ b/mod/quiz/report/analysis/report.php @@ -316,7 +316,11 @@ class quiz_report extends quiz_default_report { $q = $questions[$qnum]; $qid = $q['id']; $question = get_record('question', 'id', $qid); - $qnumber = " (".link_to_popup_window('/question/question.php?id='.$qid,'editquestion', $qid, 450, 550, get_string('edit'), 'none', true ).") "; + if (question_has_capability_on($question, 'edit') || question_has_capability_on($question, 'view')) { + $qnumber = " (".link_to_popup_window('/question/question.php?id='.$qid,'&cmid='.$cm->id.'editquestion', $qid, 450, 550, get_string('edit'), 'none', true ).") "; + } else { + $qnumber = $qid; + } $qname = '
'.format_text($question->name." : ", $question->questiontextformat, $format_options, $quiz->course).'
'; $qicon = print_question_icon($question, true); $qreview = quiz_question_preview_button($quiz, $question);