From 20482f9d41ac20bcc9dd9be31cfcadf4bb6ed688 Mon Sep 17 00:00:00 2001 From: Tim Hunt Date: Mon, 25 Jun 2018 15:05:33 +0100 Subject: [PATCH] MDL-62792 filter_mathjaxloader: don't use statics for once-only items --- filter/mathjaxloader/filter.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/filter/mathjaxloader/filter.php b/filter/mathjaxloader/filter.php index a6010bfbcad..50e568e45d2 100644 --- a/filter/mathjaxloader/filter.php +++ b/filter/mathjaxloader/filter.php @@ -79,10 +79,8 @@ class filter_mathjaxloader extends moodle_text_filter { * @param context $context The current context. */ public function setup($page, $context) { - // This only requires execution once per request. - static $jsinitialised = false; - if (empty($jsinitialised)) { + if ($page->requires->should_create_one_time_item_now('filter_mathjaxloader-scripts')) { $url = get_config('filter_mathjaxloader', 'httpsurl'); $lang = $this->map_language_code(current_language()); $url = new moodle_url($url, array('delayStartupUntil' => 'configured')); @@ -102,8 +100,6 @@ class filter_mathjaxloader extends moodle_text_filter { $params = array('mathjaxconfig' => $config, 'lang' => $lang); $page->requires->yui_module('moodle-filter_mathjaxloader-loader', 'M.filter_mathjaxloader.configure', array($params)); - - $jsinitialised = true; } }