L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-35628 performance: Remove dirname() where possible.

Browse Source 
dirname() is a slow function compared with __DIR__ and using
'/../'.  Moodle has a large number of legacy files that are included
each time a page loads and is not able to use an autoloader as it is
functional code.  This allows those required includes to perform as
best as possible in this situation.
This commit is contained in:
Russell Smith
2016-06-10 08:06:49 +10:00
parent 4ee8ef5d41
commit 1fcf0ca8a5
352 changed files with 499 additions and 499 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mod/workshop/allocation/manual/lib.php
+2 -2
View File
@@ -26,8 +26,8 @@
defined('MOODLE_INTERNAL') || die();
require_once(dirname(dirname(__FILE__)) . '/lib.php'); // interface definition
require_once(dirname(dirname(dirname(__FILE__))) . '/locallib.php'); // workshop internal API
require_once(__DIR__ . '/../lib.php'); // interface definition
require_once(__DIR__ . '/../../locallib.php'); // workshop internal API
/**
* Allows users to allocate submissions for review manually
mod/workshop/allocation/random/lib.php
+3 -3
View File
@@ -28,9 +28,9 @@ defined('MOODLE_INTERNAL') || die();
global $CFG; // access to global variables during unit test
require_once(dirname(dirname(__FILE__)) . '/lib.php'); // interface definition
require_once(dirname(dirname(dirname(__FILE__))) . '/locallib.php'); // workshop internal API
require_once(dirname(__FILE__) . '/settings_form.php'); // settings form
require_once(__DIR__ . '/../lib.php'); // interface definition
require_once(__DIR__ . '/../../locallib.php'); // workshop internal API
require_once(__DIR__ . '/settings_form.php'); // settings form
/**
* Allocates the submissions randomly
mod/workshop/allocation/random/settings.php
+1 -1
View File
@@ -26,7 +26,7 @@
defined('MOODLE_INTERNAL') || die();
require_once(dirname(__FILE__) . '/lib.php');
require_once(__DIR__ . '/lib.php');
$settings->add(new admin_setting_configselect('workshopallocation_random/numofreviews',
get_string('numofreviews', 'workshopallocation_random'),
mod/workshop/allocation/scheduled/lib.php
+4 -4
View File
@@ -26,10 +26,10 @@
defined('MOODLE_INTERNAL') || die();
require_once(dirname(dirname(__FILE__)) . '/lib.php'); // interface definition
require_once(dirname(dirname(dirname(__FILE__))) . '/locallib.php'); // workshop internal API
require_once(dirname(dirname(__FILE__)) . '/random/lib.php'); // random allocator
require_once(dirname(__FILE__) . '/settings_form.php'); // our settings form
require_once(__DIR__ . '/../lib.php'); // interface definition
require_once(__DIR__ . '/../../locallib.php'); // workshop internal API
require_once(__DIR__ . '/../random/lib.php'); // random allocator
require_once(__DIR__ . '/settings_form.php'); // our settings form
/**
* Allocates the submissions randomly in a cronjob task
mod/workshop/allocation/scheduled/settings_form.php
+1 -1
View File
@@ -27,7 +27,7 @@
defined('MOODLE_INTERNAL') || die();
require_once($CFG->dirroot.'/lib/formslib.php');
require_once(dirname(dirname(__FILE__)) . '/random/settings_form.php'); // parent form
require_once(__DIR__ . '/../random/settings_form.php'); // parent form
/**
* Allocator settings form