L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-83994 course: Improve PHPUnit tests for delete_section

Browse Source
This commit is contained in:
Sara Arjona
2025-04-11 11:33:45 +02:00
parent 0a25c4cb8f
commit 1f4313b4a9
2 changed files with 9 additions and 84 deletions
Download Patch File Download Diff File Expand all files Collapse all files
course/format/tests/external/delete_section_test.php
Vendored
+9 -21
View File
@@ -37,14 +37,6 @@ require_once($CFG->dirroot . '/webservice/tests/helpers.php');
*/
final class delete_section_test extends \externallib_advanced_testcase {
/**
* Setup to ensure that fixtures are loaded.
*/
public static function setupBeforeClass(): void { // phpcs:ignore
global $CFG;
require_once($CFG->dirroot . '/course/format/tests/fixtures/format_theunittestdelete.php');
}
/**
* Test the webservice can execute the section_delete action.
*
@@ -52,16 +44,15 @@ final class delete_section_test extends \externallib_advanced_testcase {
* @dataProvider section_delete_provider
* @param int $sectionum
* @param string $format
* @param array $formatoptions
* @param int $expectedsectionum
*
* @throws \moodle_exception
*/
public function test_delete_section(int $sectionum, string $format, array $formatoptions, int $expectedsectionum): void {
public function test_delete_section(int $sectionum, string $format, int $expectedsectionum): void {
$this->resetAfterTest();
$course =
$this->getDataGenerator()->create_course(['numsections' => $sectionum, 'format' => $format, ...$formatoptions]);
$this->getDataGenerator()->create_course(['numsections' => $sectionum, 'format' => $format]);
$teacher = $this->getDataGenerator()->create_and_enrol($course, 'editingteacher');
// Execute the method.
$courseformat = course_get_format($course->id);
@@ -94,21 +85,18 @@ final class delete_section_test extends \externallib_advanced_testcase {
'format topic' => [
'sectionum' => 4,
'format' => 'topics',
'formatoptions' => [],
'expectedsectionum' => 1,
],
'format theunittestdelete' => [
'format weeks' => [
'sectionum' => 4,
'format' => 'theunittestdelete',
'formatoptions' => [],
'format' => 'weeks',
'expectedsectionum' => 1,
],
'format social' => [
'sectionum' => 4,
'format' => 'social',
'expectedsectionum' => 5,
],
'format theunittestdelete can delete' => [
'sectionum' => 4,
'format' => 'theunittestdelete',
'formatoptions' => ['can_delete_sections' => true],
'expectedsectionum' => 1,
],
];
}
}