From 1ef67caf2ce9b5a17befe0a6d56e4ac6313644aa Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Thu, 25 Mar 2021 01:23:14 +1100 Subject: [PATCH] MDL-70935 mod_quiz: Missing completionminattempts rule description The mod_quiz_get_completion_active_rule_descriptions() function was not returning the description for the 'completionminattempts' rule. Added that. --- mod/quiz/lang/en/quiz.php | 1 + mod/quiz/lib.php | 5 +++++ 2 files changed, 6 insertions(+) diff --git a/mod/quiz/lang/en/quiz.php b/mod/quiz/lang/en/quiz.php index a10474f141b..1c6f0d4a384 100644 --- a/mod/quiz/lang/en/quiz.php +++ b/mod/quiz/lang/en/quiz.php @@ -180,6 +180,7 @@ $string['commentorgrade'] = 'Make comment or override grade'; $string['comments'] = 'Comments'; $string['completedon'] = 'Completed on'; $string['completionminattempts'] = 'Minimum number of attempts:'; +$string['completionminattemptsdesc'] = 'Minimum number of attempts required: {$a}'; $string['completionminattemptsgroup'] = 'Require attempts'; $string['completionminattemptserror'] = 'Minimum number of attempts must be lower or equal to attempts allowed.'; $string['completionpass'] = 'Require passing grade'; diff --git a/mod/quiz/lib.php b/mod/quiz/lib.php index 2d9877ab9da..f7fd80d6f31 100644 --- a/mod/quiz/lib.php +++ b/mod/quiz/lib.php @@ -2222,6 +2222,11 @@ function mod_quiz_get_completion_active_rule_descriptions($cm) { $descriptions[] = get_string('completionpassdesc', 'quiz', format_time($val)); } break; + case 'completionminattempts': + if (!empty($val)) { + $descriptions[] = get_string('completionminattemptsdesc', 'quiz', $val); + } + break; default: break; }