L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-15402: when an instance is reaonly, the administrator cannot delete it but should be able to modify the name (only)

Browse Source
This commit is contained in:
jerome
2008-09-19 06:43:06 +00:00
parent ce2066a1c2
commit 1e97f196a4
2 changed files with 32 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
admin/repositoryinstance.php
+4 -6
View File
@@ -43,10 +43,6 @@ $return = true;
if (!empty($edit) || !empty($new)) {
if (!empty($edit)) {
$instance = repository_get_instance($edit);
//if you try to edit an instance set as readonly, display an error message
if ($instance->readonly) {
throw new repository_exception('readonlyinstance', 'repository');
}
$instancetype = repository_get_type_by_id($instance->typeid);
$classname = 'repository_' . $instancetype->get_typename();
$configs = $instance->get_instance_option_names();
@@ -72,8 +68,10 @@ if (!empty($edit) || !empty($new)) {
if ($edit) {
$settings = array();
$settings['name'] = $fromform->name;
foreach($configs as $config) {
$settings[$config] = $fromform->$config;
if (!$instance->readonly) {
foreach($configs as $config) {
$settings[$config] = $fromform->$config;
}
}
$success = $instance->set_option($settings);
} else {