From 19ad96aee3252015d21cfc8ad68ba0ded472a7ca Mon Sep 17 00:00:00 2001 From: Jakob Date: Tue, 3 Nov 2015 10:41:03 -0800 Subject: [PATCH] MDL-51899 mod/assign: Allow 0.00 grades while editing a grade. The function unformat_float can return 0 and false. We need to do strict comparison for the return value on line 92 to accept grades 0.00. --- mod/assign/gradeform.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mod/assign/gradeform.php b/mod/assign/gradeform.php index 598a1b51f85..74a407b96af 100644 --- a/mod/assign/gradeform.php +++ b/mod/assign/gradeform.php @@ -89,7 +89,7 @@ class mod_assign_grade_form extends moodleform { } if ($instance->grade > 0) { - if (!unformat_float($data['grade'], true) && (!empty($data['grade']))) { + if (unformat_float($data['grade'], true) === false && (!empty($data['grade']))) { $errors['grade'] = get_string('invalidfloatforgrade', 'assign', $data['grade']); } else if (unformat_float($data['grade']) > $instance->grade) { $errors['grade'] = get_string('gradeabovemaximum', 'assign', $instance->grade);