L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-78297 core: Less cache lookups in deprecated capabilities feature

Browse Source 
Avoid use of $cache->has.
This commit is contained in:
Martin Gauk
2023-06-07 12:04:36 +02:00
parent 03b605f2eb
commit 190db6962e
2 changed files with 11 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/accesslib.php
+9 -11
View File
@@ -2555,13 +2555,10 @@ function get_capability_info($capabilityname) {
* @return stdClass|null with deprecation message and potential replacement if not null
*/
function get_deprecated_capability_info($capabilityname) {
// Here if we do like get_all_capabilities, we run into performance issues as the full array is unserialised each time.
// We could have used an adhoc task but this also had performance issue. Last solution was to create a cache using
// the official caches.php file. The performance issue shows in test_permission_evaluation.
$cache = cache::make('core', 'deprecatedcapabilities');
// Cache has not be initialised.
if (!$cache->get('deprecated_capabilities_initialised')) {
// Look for deprecated capabilities in each components.
$cache = cache::make('core', 'capabilities');
$alldeprecatedcaps = $cache->get('deprecated_capabilities');
if ($alldeprecatedcaps === false) {
// Look for deprecated capabilities in each component.
$allcaps = get_all_capabilities();
$components = [];
$alldeprecatedcaps = [];
@@ -2574,18 +2571,19 @@ function get_deprecated_capability_info($capabilityname) {
require($defpath);
if (!empty($deprecatedcapabilities)) {
foreach ($deprecatedcapabilities as $cname => $cdef) {
$cache->set($cname, $cdef);
$alldeprecatedcaps[$cname] = $cdef;
}
}
}
}
}
$cache->set('deprecated_capabilities_initialised', true);
$cache->set('deprecated_capabilities', $alldeprecatedcaps);
}
if (!$cache->has($capabilityname)) {
if (!isset($alldeprecatedcaps[$capabilityname])) {
return null;
}
$deprecatedinfo = $cache->get($capabilityname);
$deprecatedinfo = $alldeprecatedcaps[$capabilityname];
$deprecatedinfo['fullmessage'] = "The capability '{$capabilityname}' is deprecated.";
if (!empty($deprecatedinfo['message'])) {
$deprecatedinfo['fullmessage'] .= $deprecatedinfo['message'];