From 181bfa417b59e3f2e95eb20b6bd4dfbe5c991066 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luca=20B=C3=B6sch?= Date: Fri, 23 Feb 2024 17:12:10 +0100 Subject: [PATCH] MDL-73120 mod_h5pactivity: Precisely define the "grade" lang string. AMOS BEGIN MOV [grade_h5p,mod_h5pactivity],[gradenoun_h5p,mod_h5pactivity] AMOS END --- mod/h5pactivity/lang/en/deprecated.txt | 1 + mod/h5pactivity/lang/en/h5pactivity.php | 5 ++++- mod/h5pactivity/lib.php | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 mod/h5pactivity/lang/en/deprecated.txt diff --git a/mod/h5pactivity/lang/en/deprecated.txt b/mod/h5pactivity/lang/en/deprecated.txt new file mode 100644 index 00000000000..9c77acacaa8 --- /dev/null +++ b/mod/h5pactivity/lang/en/deprecated.txt @@ -0,0 +1 @@ +grade_h5p,mod_h5pactivity diff --git a/mod/h5pactivity/lang/en/h5pactivity.php b/mod/h5pactivity/lang/en/h5pactivity.php index 67d661a0c23..b4aa47d3252 100644 --- a/mod/h5pactivity/lang/en/h5pactivity.php +++ b/mod/h5pactivity/lang/en/h5pactivity.php @@ -80,7 +80,7 @@ $string['grade_highest_attempt'] = 'Highest grade'; $string['grade_average_attempt'] = 'Average grade'; $string['grade_last_attempt'] = 'Last attempt'; $string['grade_first_attempt'] = 'First attempt'; -$string['grade_h5p'] = 'Grade: {$a}'; +$string['gradenoun_h5p'] = 'Grade: {$a}'; $string['h5pactivity:addinstance'] = 'Add a new H5P'; $string['h5pactivity:reviewattempts'] = 'Review H5P attempts'; $string['h5pactivity:submit'] = 'Submit H5P attempts'; @@ -148,3 +148,6 @@ $string['usecontentbank'] = 'Use the content bank $string['view'] = 'View'; $string['viewattempts'] = 'View attempts ({$a})'; $string['view_report'] = 'View report'; + +// Deprecated since Moodle 4.4. +$string['grade_h5p'] = 'Grade: {$a}'; diff --git a/mod/h5pactivity/lib.php b/mod/h5pactivity/lib.php index 831d93f1245..0e27d6bfa57 100644 --- a/mod/h5pactivity/lib.php +++ b/mod/h5pactivity/lib.php @@ -755,7 +755,7 @@ function h5pactivity_print_recent_mod_activity(stdClass $activity, int $courseid 'userurl' => new moodle_url('/user/view.php', array('id' => $activity->user->id, 'course' => $courseid)), 'fullname' => $activity->user->fullname]; if (isset($activity->grade)) { - $template['grade'] = get_string('grade_h5p', 'h5pactivity', $activity->grade); + $template['grade'] = get_string('gradenoun_h5p', 'h5pactivity', $activity->grade); } echo $OUTPUT->render_from_template('mod_h5pactivity/reviewattempts', $template);