From 177cc379edacdffa783729f6828ff9fddb446c6d Mon Sep 17 00:00:00 2001 From: Damyon Wiese Date: Tue, 17 Jun 2014 10:19:55 +0800 Subject: [PATCH] MDL-45582 Editpdf: Prevent debugging when there is no pdf --- mod/assign/feedback/editpdf/locallib.php | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/mod/assign/feedback/editpdf/locallib.php b/mod/assign/feedback/editpdf/locallib.php index 9e42ab0159e..f98bee9cd2e 100644 --- a/mod/assign/feedback/editpdf/locallib.php +++ b/mod/assign/feedback/editpdf/locallib.php @@ -192,10 +192,13 @@ class assign_feedback_editpdf extends assign_feedback_plugin { * @return bool */ public function save(stdClass $grade, stdClass $data) { - $sourceuserid = $data->editpdf_source_userid; - // Copy drafts annotations and comments if current user is different to sourceuserid. - if ($sourceuserid != $grade->userid) { - page_editor::copy_drafts_from_to($this->assignment, $grade, $sourceuserid); + // Source user id is only added to the form if there was a pdf. + if (!empty($data->editpdf_source_userid)) { + $sourceuserid = $data->editpdf_source_userid; + // Copy drafts annotations and comments if current user is different to sourceuserid. + if ($sourceuserid != $grade->userid) { + page_editor::copy_drafts_from_to($this->assignment, $grade, $sourceuserid); + } } if (page_editor::has_annotations_or_comments($grade->id, true)) { document_services::generate_feedback_document($this->assignment, $grade->userid, $grade->attemptnumber);