From e34f261d5e5184986861ee10b176ecb537d504b0 Mon Sep 17 00:00:00 2001 From: Andrew Nicols Date: Wed, 9 May 2018 19:57:45 +0800 Subject: [PATCH 1/3] MDL-61858 core_privacy: Add test to ensure component implementations --- privacy/tests/provider_test.php | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/privacy/tests/provider_test.php b/privacy/tests/provider_test.php index 943d54e7643..496d99678b4 100644 --- a/privacy/tests/provider_test.php +++ b/privacy/tests/provider_test.php @@ -163,6 +163,18 @@ class provider_testcase extends advanced_testcase { } } + /** + * Test that all providers implement some form of compliant provider. + * + * @dataProvider get_component_list + * @param string $component frankenstyle component name, e.g. 'mod_assign' + * @param string $classname the fully qualified provider classname + */ + public function test_all_providers_compliant($component, $classname) { + $manager = new manager(); + $this->assertTrue($manager->component_is_compliant($component)); + } + /** * Data provider for the metadata\provider tests. * From 37474019922ff8ddc3cc2ce8df92363413f93c62 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Fri, 11 May 2018 16:34:31 +0800 Subject: [PATCH 2/3] MDL-61858 core_portfolio: added missing metadata implementation --- portfolio/boxnet/classes/privacy/provider.php | 1 + portfolio/flickr/classes/privacy/provider.php | 1 + portfolio/googledocs/classes/privacy/provider.php | 1 + portfolio/mahara/classes/privacy/provider.php | 1 + portfolio/picasa/classes/privacy/provider.php | 1 + 5 files changed, 5 insertions(+) diff --git a/portfolio/boxnet/classes/privacy/provider.php b/portfolio/boxnet/classes/privacy/provider.php index 977114983e4..b8506b3029e 100644 --- a/portfolio/boxnet/classes/privacy/provider.php +++ b/portfolio/boxnet/classes/privacy/provider.php @@ -36,6 +36,7 @@ use core_privacy\local\metadata\collection; class provider implements // This portfolio plugin does not store any data itself. // It has no database tables, and it purely acts as a conduit, sending data externally. + \core_privacy\local\metadata\provider, \core_portfolio\privacy\portfolio_provider { /** diff --git a/portfolio/flickr/classes/privacy/provider.php b/portfolio/flickr/classes/privacy/provider.php index 8b272b9a4ca..c041bed8717 100644 --- a/portfolio/flickr/classes/privacy/provider.php +++ b/portfolio/flickr/classes/privacy/provider.php @@ -36,6 +36,7 @@ use core_privacy\local\metadata\collection; class provider implements // This portfolio plugin does not store any data itself. // It has no database tables, and it purely acts as a conduit, sending data externally. + \core_privacy\local\metadata\provider, \core_portfolio\privacy\portfolio_provider { /** diff --git a/portfolio/googledocs/classes/privacy/provider.php b/portfolio/googledocs/classes/privacy/provider.php index cd2505f0764..505340ae20a 100644 --- a/portfolio/googledocs/classes/privacy/provider.php +++ b/portfolio/googledocs/classes/privacy/provider.php @@ -36,6 +36,7 @@ use core_privacy\local\metadata\collection; class provider implements // This portfolio plugin does not store any data itself. // It has no database tables, and it purely acts as a conduit, sending data externally. + \core_privacy\local\metadata\provider, \core_portfolio\privacy\portfolio_provider { /** diff --git a/portfolio/mahara/classes/privacy/provider.php b/portfolio/mahara/classes/privacy/provider.php index d73e39ebc65..eb7b395460d 100644 --- a/portfolio/mahara/classes/privacy/provider.php +++ b/portfolio/mahara/classes/privacy/provider.php @@ -36,6 +36,7 @@ use core_privacy\local\metadata\collection; class provider implements // This portfolio plugin does not store any data itself. // It has no database tables, and it purely acts as a conduit, sending data externally. + \core_privacy\local\metadata\provider, \core_portfolio\privacy\portfolio_provider { /** diff --git a/portfolio/picasa/classes/privacy/provider.php b/portfolio/picasa/classes/privacy/provider.php index 00d0828ed1e..317cf262eec 100644 --- a/portfolio/picasa/classes/privacy/provider.php +++ b/portfolio/picasa/classes/privacy/provider.php @@ -36,6 +36,7 @@ use core_privacy\local\metadata\collection; class provider implements // This portfolio plugin does not store any data itself. // It has no database tables, and it purely acts as a conduit, sending data externally. + \core_privacy\local\metadata\provider, \core_portfolio\privacy\portfolio_provider { /** From 739e7f5c79da97e4d1ebb64e6aea2fe49a400242 Mon Sep 17 00:00:00 2001 From: Mark Nelson Date: Fri, 11 May 2018 17:35:53 +0800 Subject: [PATCH 3/3] MDL-61858 gradingform_guide: added missing metadata implementation --- grade/grading/form/guide/classes/privacy/provider.php | 1 + 1 file changed, 1 insertion(+) diff --git a/grade/grading/form/guide/classes/privacy/provider.php b/grade/grading/form/guide/classes/privacy/provider.php index b7908c93e7a..98653475a6d 100644 --- a/grade/grading/form/guide/classes/privacy/provider.php +++ b/grade/grading/form/guide/classes/privacy/provider.php @@ -37,6 +37,7 @@ use \core_privacy\local\request\writer; * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later */ class provider implements + \core_privacy\local\metadata\provider, \core_privacy\local\request\user_preference_provider { /**