diff --git a/lib/tests/authlib_test.php b/lib/tests/authlib_test.php index 5594c0f9833..6d929c062e2 100644 --- a/lib/tests/authlib_test.php +++ b/lib/tests/authlib_test.php @@ -29,7 +29,7 @@ defined('MOODLE_INTERNAL') || die(); /** * Functional test for authentication related APIs. */ -class authlib_testcase extends advanced_testcase { +class core_authlib_testcase extends advanced_testcase { public function test_lockout() { global $CFG; require_once("$CFG->libdir/authlib.php"); @@ -45,7 +45,6 @@ class authlib_testcase extends advanced_testcase { $user = $this->getDataGenerator()->create_user(); - // Test lockout is disabled when threshold not set. $this->assertFalse(login_is_lockedout($user)); @@ -55,7 +54,6 @@ class authlib_testcase extends advanced_testcase { login_attempt_failed($user); $this->assertFalse(login_is_lockedout($user)); - // Test lockout threshold works. set_config('lockoutthreshold', 3); @@ -68,13 +66,11 @@ class authlib_testcase extends advanced_testcase { $this->assertContains('noemailever', $output); $this->assertTrue(login_is_lockedout($user)); - // Test unlock works. login_unlock_account($user); $this->assertFalse(login_is_lockedout($user)); - // Test lockout window works. login_attempt_failed($user); @@ -84,7 +80,6 @@ class authlib_testcase extends advanced_testcase { login_attempt_failed($user); $this->assertFalse(login_is_lockedout($user)); - // Test valid login resets window. login_attempt_valid($user); @@ -93,7 +88,6 @@ class authlib_testcase extends advanced_testcase { login_attempt_failed($user); $this->assertFalse(login_is_lockedout($user)); - // Test lock duration works. ob_start(); // Prevent nomailever notice. @@ -106,7 +100,6 @@ class authlib_testcase extends advanced_testcase { set_user_preference('login_lockout', time()-60*30-10, $user); $this->assertFalse(login_is_lockedout($user)); - // Test lockout ignored pref works. set_user_preference('login_lockout_ignored', 1, $user); @@ -166,8 +159,8 @@ class authlib_testcase extends advanced_testcase { $this->assertFalse($result); $this->assertEquals(AUTH_LOGIN_NOUSER, $reason); - set_config('lockoutthreshold', 3); + $reason = null; $result = authenticate_user_login('username1', 'nopass', false, $reason); $this->assertFalse($result);