From 13df8afd1ed0dac89c4425c4bc28a4e386e2f36c Mon Sep 17 00:00:00 2001 From: Amaia Anabitarte Date: Mon, 8 Sep 2025 15:29:38 +0200 Subject: [PATCH] MDL-86564 mod_choice: Export a pix_icon in overview external --- public/mod/choice/classes/courseformat/overview.php | 12 ++++++------ .../mod/choice/tests/courseformat/overview_test.php | 6 +++++- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/public/mod/choice/classes/courseformat/overview.php b/public/mod/choice/classes/courseformat/overview.php index db7dd6df3b1..69676e8b362 100644 --- a/public/mod/choice/classes/courseformat/overview.php +++ b/public/mod/choice/classes/courseformat/overview.php @@ -17,6 +17,7 @@ namespace mod_choice\courseformat; use cm_info; +use core\output\pix_icon; use mod_choice\manager; use core\activity_dates; use core\output\action_link; @@ -136,14 +137,13 @@ class overview extends \core_courseformat\activityoverviewbase { if ($status) { $statustext = get_string('answered', 'choice'); } - $corerenderer = $this->rendererhelper->get_core_renderer(); $submittedstatuscontent = "-"; if ($status) { - $submittedstatuscontent = $corerenderer->pix_icon( - 'i/checkedcircle', - $statustext, - 'core', - ['class' => 'text-success'], + $submittedstatuscontent = new pix_icon( + pix: 'i/checkedcircle', + alt: $statustext, + component: 'core', + attributes: ['class' => 'text-success'], ); } return new overviewitem( diff --git a/public/mod/choice/tests/courseformat/overview_test.php b/public/mod/choice/tests/courseformat/overview_test.php index 4316521afeb..46877e70481 100644 --- a/public/mod/choice/tests/courseformat/overview_test.php +++ b/public/mod/choice/tests/courseformat/overview_test.php @@ -16,6 +16,7 @@ namespace mod_choice\courseformat; +use core\output\pix_icon; use core_courseformat\local\overview\overviewfactory; /** @@ -49,8 +50,11 @@ final class overview_test extends \advanced_testcase { $this->assertNull($actionoverview['responded']); } else { $this->assertEquals($answered, $actionoverview['responded']->get_value()); + $content = $actionoverview['responded']->get_content(); if (!$answered) { - $this->assertEquals('-', $actionoverview['responded']->get_content()); + $this->assertEquals('-', $content); + } else { + $this->assertInstanceOf(pix_icon::class, $content); } } }