diff --git a/lib/accesslib.php b/lib/accesslib.php
index 900148dfe1d..325bd485b50 100755
--- a/lib/accesslib.php
+++ b/lib/accesslib.php
@@ -2224,7 +2224,7 @@ function create_context($contextlevel, $instanceid) {
// Only non-pinned & course-page based
$sql = "SELECT ctx.path, ctx.depth
FROM {context} ctx
- JOIN {block_instances} bi ON (bi.contextid=ctx.id)
+ JOIN {block_instances} bi ON (bi.parentcontextid=ctx.id)
WHERE bi.id=? AND ctx.contextlevel=?";
$params = array($instanceid, CONTEXT_COURSE);
if ($p = $DB->get_record_sql($sql, $params)) {
@@ -2539,7 +2539,7 @@ function preload_course_contexts($courseid) {
SELECT x.instanceid, x.id, x.contextlevel, x.path, x.depth
FROM {context} px
- JOIN {block_instances} bi ON bi.contextid = px.id
+ JOIN {block_instances} bi ON bi.parentcontextid = px.id
JOIN {context} x ON x.instanceid=bi.id
WHERE px.instanceid = ? AND px.contextlevel = ".CONTEXT_COURSE."
AND x.contextlevel=".CONTEXT_BLOCK."
@@ -6076,7 +6076,7 @@ function build_context_path($force=false) {
SELECT ctx.id, ".$DB->sql_concat('pctx.path', "'/'", 'ctx.id').", pctx.depth+1
FROM {context} ctx
JOIN {block_instances} bi ON ctx.instanceid = bi.id
- JOIN {context} pctx ON bi.contextid = pctx.id
+ JOIN {context} pctx ON bi.parentcontextid = pctx.id
WHERE ctx.contextlevel=".CONTEXT_BLOCK."
AND NOT EXISTS (SELECT 'x'
FROM {context_temp} temp
diff --git a/lib/blocklib.php b/lib/blocklib.php
index 2cca159d1b0..f6cb661198d 100644
--- a/lib/blocklib.php
+++ b/lib/blocklib.php
@@ -25,21 +25,30 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
-/**
- * Block Defines
+/**#@+
+ * @deprecated since Moodle 2.0. No longer used.
*/
define('BLOCK_MOVE_LEFT', 0x01);
define('BLOCK_MOVE_RIGHT', 0x02);
define('BLOCK_MOVE_UP', 0x04);
define('BLOCK_MOVE_DOWN', 0x08);
define('BLOCK_CONFIGURE', 0x10);
+/**#@-*/
+/**#@+
+ * Default names for the block regions in the standard theme.
+ */
define('BLOCK_POS_LEFT', 'side-pre');
define('BLOCK_POS_RIGHT', 'side-post');
+/**#@-*/
+/**#@+
+ * @deprecated since Moodle 2.0. No longer used.
+ */
define('BLOCKS_PINNED_TRUE',0);
define('BLOCKS_PINNED_FALSE',1);
define('BLOCKS_PINNED_BOTH',2);
+/**#@-*/
/**
* Exception thrown when someone tried to do something with a block that does
@@ -379,13 +388,13 @@ class block_manager {
}
$context = $this->page->context;
- $contexttest = 'bi.contextid = :contextid2';
+ $contexttest = 'bi.parentcontextid = :contextid2';
$parentcontextparams = array();
$parentcontextids = get_parent_contexts($context);
if ($parentcontextids) {
list($parentcontexttest, $parentcontextparams) =
$DB->get_in_or_equal($parentcontextids, SQL_PARAMS_NAMED, 'parentcontext0000');
- $contexttest = "($contexttest OR (bi.showinsubcontexts = 1 AND bi.contextid $parentcontexttest))";
+ $contexttest = "($contexttest OR (bi.showinsubcontexts = 1 AND bi.parentcontextid $parentcontexttest))";
}
$pagetypepatterns = $this->matching_page_type_patterns($this->page->pagetype);
@@ -403,7 +412,7 @@ class block_manager {
bi.id,
bp.id AS blockpositionid,
bi.blockname,
- bi.contextid,
+ bi.parentcontextid,
bi.showinsubcontexts,
bi.pagetypepattern,
bi.subpagepattern,
@@ -473,7 +482,7 @@ class block_manager {
$blockinstance = new stdClass;
$blockinstance->blockname = $blockname;
- $blockinstance->contextid = $this->page->context->id;
+ $blockinstance->parentcontextid = $this->page->context->id;
$blockinstance->showinsubcontexts = !empty($showinsubcontexts);
$blockinstance->pagetypepattern = $pagetypepattern;
$blockinstance->subpagepattern = $subpagepattern;
@@ -902,7 +911,7 @@ function blocks_delete_all_for_context($contextid) {
blocks_delete_instance($instance, true);
}
$instances->close();
- $DB->delete_records('block_instances', array('contextid' => $contextid));
+ $DB->delete_records('block_instances', array('parentcontextid' => $contextid));
$DB->delete_records('block_positions', array('contextid' => $contextid));
}
@@ -1204,7 +1213,7 @@ function blocks_execute_action($page, &$blockmanager, $blockaction, $instanceori
$region = $page->blocks->get_default_region();
$weight = $DB->get_field_sql("SELECT MAX(defaultweight) FROM {block_instances}
- WHERE contextid = ? AND defaultregion = ?", array($page->context->id, $region));
+ WHERE parentcontextid = ? AND defaultregion = ?", array($page->context->id, $region));
$pagetypepattern = $page->pagetype;
if (strpos($pagetypepattern, 'course-view') === 0) {
$pagetypepattern = 'course-view-*';
diff --git a/lib/db/install.xml b/lib/db/install.xml
index 63412c2575d..6188bb2709f 100644
--- a/lib/db/install.xml
+++ b/lib/db/install.xml
@@ -2177,12 +2177,12 @@