diff --git a/mod/lti/tests/behat/toolconfigure.feature b/mod/lti/tests/behat/toolconfigure.feature
index 171ebee8e10..3622bf80962 100644
--- a/mod/lti/tests/behat/toolconfigure.feature
+++ b/mod/lti/tests/behat/toolconfigure.feature
@@ -22,7 +22,7 @@ Feature: Configure tool types
@javascript
Scenario: Add a tool type from a cartridge URL
When I set the field "url" to local url "/mod/lti/tests/fixtures/ims_cartridge_basic_lti_link.xml"
- And I press "Add"
+ And I press "Add Legacy LTI"
Then I should see "Enter your consumer key and shared secret"
And I press "Save changes"
And I should see "Example tool"
@@ -30,7 +30,7 @@ Feature: Configure tool types
@javascript
Scenario: Try to add a non-existant cartridge
When I set the field "url" to local url "/mod/lti/tests/fixtures/nonexistant.xml"
- And I press "Add"
+ And I press "Add Legacy LTI"
Then I should see "Enter your consumer key and shared secret"
And I press "Save changes"
And I should see "Failed to create new tool. Please check the URL and try again."
@@ -38,6 +38,6 @@ Feature: Configure tool types
@javascript
Scenario: Attempt to add a tool type from a configuration URL, then cancel
When I set the field "url" to local url "/mod/lti/tests/fixtures/tool_provider.php"
- And I press "Add"
+ And I press "Add Legacy LTI"
Then I should see "Cancel"
And I press "cancel-external-registration"
diff --git a/mod/lti/tests/openidregistration_test.php b/mod/lti/tests/openidregistration_test.php
new file mode 100644
index 00000000000..af678295506
--- /dev/null
+++ b/mod/lti/tests/openidregistration_test.php
@@ -0,0 +1,269 @@
+.
+//
+// This file is part of BasicLTI4Moodle
+//
+// BasicLTI4Moodle is an IMS BasicLTI (Basic Learning Tools for Interoperability)
+// consumer for Moodle 1.9 and Moodle 2.0. BasicLTI is a IMS Standard that allows web
+// based learning tools to be easily integrated in LMS as native ones. The IMS BasicLTI
+// specification is part of the IMS standard Common Cartridge 1.1 Sakai and other main LMS
+// are already supporting or going to support BasicLTI. This project Implements the consumer
+// for Moodle. Moodle is a Free Open source Learning Management System by Martin Dougiamas.
+// BasicLTI4Moodle is a project iniciated and leaded by Ludo(Marc Alier) and Jordi Piguillem
+// at the GESSI research group at UPC.
+// SimpleLTI consumer for Moodle is an implementation of the early specification of LTI
+// by Charles Severance (Dr Chuck) htp://dr-chuck.com , developed by Jordi Piguillem in a
+// Google Summer of Code 2008 project co-mentored by Charles Severance and Marc Alier.
+//
+// BasicLTI4Moodle is copyright 2009 by Marc Alier Forment, Jordi Piguillem and Nikolas Galanis
+// of the Universitat Politecnica de Catalunya http://www.upc.edu
+// Contact info: Marc Alier Forment granludo @ gmail.com or marc.alier @ upc.edu.
+
+/**
+ * This file contains unit tests for lti/openidregistrationlib.php
+ *
+ * @package mod_lti
+ * @copyright 2020 Claude Vervoort, Cengage
+ * @author Claude Vervoort
+ * @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+
+use mod_lti\local\ltiopenid\registration_exception;
+use mod_lti\local\ltiopenid\registration_helper;
+
+/**
+ * OpenId LTI Registration library tests
+ */
+class mod_lti_openidregistrationlib_testcase extends advanced_testcase {
+
+ /**
+ * @var string A has-it-all client registration.
+ */
+ private $registrationfulljson = <<registrationfulljson, true);
+ $registration['scope'] .= ' https://purl.imsglobal.org/spec/lti-nrps/scope/contextmembership.readonly';
+ $config = registration_helper::registration_to_config($registration, 'TheClientId');
+ $this->assertEquals('JWK_KEYSET', $config->lti_keytype);
+ $this->assertEquals(LTI_VERSION_1P3, $config->lti_ltiversion);
+ $this->assertEquals('TheClientId', $config->lti_clientid);
+ $this->assertEquals('Virtual Garden', $config->lti_typename);
+ $this->assertEquals('Learn Botany by tending to your little (virtual) garden.', $config->lti_description);
+ $this->assertEquals('https://client.example.org/lti/init', $config->lti_initiatelogin);
+ $this->assertEquals(implode(PHP_EOL, ["https://client.example.org/callback",
+ "https://client.example.org/callback2"]), $config->lti_redirectionuris);
+ $this->assertEquals("context_history=\$Context.id.history", $config->lti_customparameters);
+ $this->assertEquals("https://client.example.org/.well-known/jwks.json", $config->lti_publickeyset);
+ $this->assertEquals("https://client.example.org/logo.png", $config->lti_icon);
+ $this->assertEquals(2, $config->ltiservice_gradesynchronization);
+ $this->assertEquals(LTI_SETTING_DELEGATE, $config->lti_acceptgrades);
+ $this->assertEquals(1, $config->ltiservice_memberships);
+ $this->assertEquals(0, $config->ltiservice_toolsettings);
+ $this->assertEquals(LTI_SETTING_ALWAYS, $config->lti_sendname);
+ $this->assertEquals(LTI_SETTING_ALWAYS, $config->lti_sendemailaddr);
+ $this->assertEquals(1, $config->lti_contentitem);
+ $this->assertEquals('https://client.example.org/lti/dl', $config->lti_toolurl_ContentItemSelectionRequest);
+ }
+
+ /**
+ * Test the mapping from Registration JSON to LTI Config for a minimal tool registration.
+ */
+ public function test_to_config_minimal() {
+ $registration = json_decode($this->registrationminimaljson, true);
+ $config = registration_helper::registration_to_config($registration, 'TheClientId');
+ $this->assertEquals('JWK_KEYSET', $config->lti_keytype);
+ $this->assertEquals(LTI_VERSION_1P3, $config->lti_ltiversion);
+ $this->assertEquals('TheClientId', $config->lti_clientid);
+ $this->assertEquals('Virtual Garden', $config->lti_typename);
+ $this->assertEmpty($config->lti_description);
+ $this->assertEquals('https://client.example.org/lti/init', $config->lti_initiatelogin);
+ $this->assertEquals('https://client.example.org/callback', $config->lti_redirectionuris);
+ $this->assertEmpty($config->lti_customparameters);
+ $this->assertEquals("https://client.example.org/.well-known/jwks.json", $config->lti_publickeyset);
+ $this->assertEmpty($config->lti_icon);
+ $this->assertEquals(0, $config->ltiservice_gradesynchronization);
+ $this->assertEquals(LTI_SETTING_NEVER, $config->lti_acceptgrades);
+ $this->assertEquals(0, $config->ltiservice_memberships);
+ $this->assertEquals(LTI_SETTING_NEVER, $config->lti_sendname);
+ $this->assertEquals(LTI_SETTING_NEVER, $config->lti_sendemailaddr);
+ $this->assertEquals(0, $config->lti_contentitem);
+ }
+
+ /**
+ * Test the mapping from Registration JSON to LTI Config for a minimal tool with
+ * deep linking support registration.
+ */
+ public function test_to_config_minimal_with_deeplinking() {
+ $registration = json_decode($this->registrationminimaldljson, true);
+ $config = registration_helper::registration_to_config($registration, 'TheClientId');
+ $this->assertEquals(1, $config->lti_contentitem);
+ $this->assertEmpty($config->lti_toolurl_ContentItemSelectionRequest);
+ }
+
+ /**
+ * Validation Test: initiation login.
+ */
+ public function test_validation_initlogin() {
+ $registration = json_decode($this->registrationfulljson, true);
+ $this->expectException(registration_exception::class);
+ $this->expectExceptionCode(400);
+ unset($registration['initiate_login_uri']);
+ registration_helper::registration_to_config($registration, 'TheClientId');
+ }
+
+ /**
+ * Validation Test: redirect uris.
+ */
+ public function test_validation_redirecturis() {
+ $registration = json_decode($this->registrationfulljson, true);
+ $this->expectException(registration_exception::class);
+ $this->expectExceptionCode(400);
+ unset($registration['redirect_uris']);
+ registration_helper::registration_to_config($registration, 'TheClientId');
+ }
+
+ /**
+ * Validation Test: jwks uri empty.
+ */
+ public function test_validation_jwks() {
+ $registration = json_decode($this->registrationfulljson, true);
+ $this->expectException(registration_exception::class);
+ $this->expectExceptionCode(400);
+ $registration['jwks_uri'] = '';
+ registration_helper::registration_to_config($registration, 'TheClientId');
+ }
+
+ /**
+ * Test the transformation from lti config to OpenId LTI Client Registration response.
+ */
+ public function test_config_to_registration() {
+ $orig = json_decode($this->registrationfulljson, true);
+ $orig['scope'] .= ' https://purl.imsglobal.org/spec/lti-nrps/scope/contextmembership.readonly';
+ $reg = registration_helper::config_to_registration(registration_helper::registration_to_config($orig, 'clid'), 12);
+ $this->assertEquals('clid', $reg['client_id']);
+ $this->assertEquals($orig['response_types'], $reg['response_types']);
+ $this->assertEquals($orig['initiate_login_uri'], $reg['initiate_login_uri']);
+ $this->assertEquals($orig['redirect_uris'], $reg['redirect_uris']);
+ $this->assertEquals($orig['jwks_uri'], $reg['jwks_uri']);
+ $this->assertEquals($orig['logo_uri'], $reg['logo_uri']);
+ $this->assertEquals('https://purl.imsglobal.org/spec/lti-ags/scope/score '.
+ 'https://purl.imsglobal.org/spec/lti-ags/scope/result.readonly '.
+ 'https://purl.imsglobal.org/spec/lti-ags/scope/lineitem.readonly '.
+ 'https://purl.imsglobal.org/spec/lti-ags/scope/lineitem '.
+ 'https://purl.imsglobal.org/spec/lti-nrps/scope/contextmembership.readonly', $reg['scope']);
+ $ltiorig = $orig['https://purl.imsglobal.org/spec/lti-tool-configuration'];
+ $lti = $reg['https://purl.imsglobal.org/spec/lti-tool-configuration'];
+ $this->assertEquals("12", $lti['deployment_id']);
+ $this->assertEquals($ltiorig['target_link_uri'], $lti['target_link_uri']);
+ $this->assertEquals($ltiorig['domain'], $lti['domain']);
+ $this->assertEquals($ltiorig['custom_parameters'], $lti['custom_parameters']);
+ $this->assertEquals($ltiorig['description'], $lti['description']);
+ $dlmsgorig = $ltiorig['messages'][0];
+ $dlmsg = $lti['messages'][0];
+ $this->assertEquals($dlmsgorig['type'], $dlmsg['type']);
+ $this->assertEquals($dlmsgorig['target_link_uri'], $dlmsg['target_link_uri']);
+ }
+}