L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81522 phpunit: Add missing void return type to all tests

Browse Source 
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-06-11 12:18:04 +02:00
parent db07c09afc
commit 1093256560
1360 changed files with 9928 additions and 9928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
user/tests/userlib_test.php
+18 -18
View File
@@ -33,7 +33,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test user_get_user_details_courses
*/
public function test_user_get_user_details_courses() {
public function test_user_get_user_details_courses(): void {
global $DB;
$this->resetAfterTest();
@@ -75,7 +75,7 @@ class userlib_test extends \advanced_testcase {
/**
* Verify return when course groupmode set to 'no groups'.
*/
public function test_user_get_user_details_courses_groupmode_nogroups() {
public function test_user_get_user_details_courses_groupmode_nogroups(): void {
$this->resetAfterTest();
// Enrol 2 users into a course with groupmode set to 'no groups'.
@@ -95,7 +95,7 @@ class userlib_test extends \advanced_testcase {
/**
* Verify return when course groupmode set to 'separate groups'.
*/
public function test_user_get_user_details_courses_groupmode_separate() {
public function test_user_get_user_details_courses_groupmode_separate(): void {
$this->resetAfterTest();
// Enrol 2 users into a course with groupmode set to 'separate groups'.
@@ -113,7 +113,7 @@ class userlib_test extends \advanced_testcase {
/**
* Verify return when course groupmode set to 'visible groups'.
*/
public function test_user_get_user_details_courses_groupmode_visible() {
public function test_user_get_user_details_courses_groupmode_visible(): void {
$this->resetAfterTest();
// Enrol 2 users into a course with groupmode set to 'visible groups'.
@@ -135,7 +135,7 @@ class userlib_test extends \advanced_testcase {
*
* @covers ::user_get_user_details_courses
*/
public function test_user_get_user_details_courses_limit_return() {
public function test_user_get_user_details_courses_limit_return(): void {
$this->resetAfterTest();
// Setup some data.
@@ -176,7 +176,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test user_update_user.
*/
public function test_user_update_user() {
public function test_user_update_user(): void {
global $DB;
$this->resetAfterTest();
@@ -250,7 +250,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test create_users.
*/
public function test_create_users() {
public function test_create_users(): void {
global $DB;
$this->resetAfterTest();
@@ -365,7 +365,7 @@ class userlib_test extends \advanced_testcase {
* @param string $username Invalid username
* @param string $expectmessage Expected exception message
*/
public function test_create_user_invalid_username($username, $expectmessage) {
public function test_create_user_invalid_username($username, $expectmessage): void {
global $CFG;
$this->resetAfterTest();
@@ -410,7 +410,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test function user_count_login_failures().
*/
public function test_user_count_login_failures() {
public function test_user_count_login_failures(): void {
$this->resetAfterTest();
$user = $this->getDataGenerator()->create_user();
$this->assertEquals(0, get_user_preferences('login_failed_count_since_success', 0, $user));
@@ -434,7 +434,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test function user_add_password_history().
*/
public function test_user_add_password_history() {
public function test_user_add_password_history(): void {
global $DB;
$this->resetAfterTest();
@@ -508,7 +508,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test function user_add_password_history().
*/
public function test_user_is_previously_used_password() {
public function test_user_is_previously_used_password(): void {
global $DB;
$this->resetAfterTest();
@@ -576,7 +576,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test that password history is deleted together with user.
*/
public function test_delete_of_hashes_on_user_delete() {
public function test_delete_of_hashes_on_user_delete(): void {
global $DB;
$this->resetAfterTest();
@@ -604,7 +604,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test user_list_view function
*/
public function test_user_list_view() {
public function test_user_list_view(): void {
$this->resetAfterTest();
@@ -633,7 +633,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test setting the user menu avatar size.
*/
public function test_user_menu_custom_avatar_size() {
public function test_user_menu_custom_avatar_size(): void {
global $PAGE;
$this->resetAfterTest(true);
@@ -653,7 +653,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test user_can_view_profile
*/
public function test_user_can_view_profile() {
public function test_user_can_view_profile(): void {
global $DB, $CFG;
$this->resetAfterTest();
@@ -828,7 +828,7 @@ class userlib_test extends \advanced_testcase {
/**
* Test user_get_user_details
*/
public function test_user_get_user_details() {
public function test_user_get_user_details(): void {
global $DB;
$this->resetAfterTest();
@@ -879,7 +879,7 @@ class userlib_test extends \advanced_testcase {
* Ensure the fields "auth, confirmed, idnumber, lang, theme, timezone and mailformat" are present when
* calling user_get_user_details() function.
*/
public function test_user_get_user_details_missing_fields() {
public function test_user_get_user_details_missing_fields(): void {
global $CFG;
$this->resetAfterTest(true);
@@ -911,7 +911,7 @@ class userlib_test extends \advanced_testcase {
* Test user_get_user_details_permissions.
* @covers ::user_get_user_details
*/
public function test_user_get_user_details_permissions() {
public function test_user_get_user_details_permissions(): void {
global $CFG;
$this->resetAfterTest();