L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81522 phpunit: Add missing void return type to all tests

Browse Source 
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-06-11 12:18:04 +02:00
parent db07c09afc
commit 1093256560
1360 changed files with 9928 additions and 9928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
question/format/xml/tests/xmlformat_test.php
+33 -33
View File
@@ -115,19 +115,19 @@ class xmlformat_test extends \question_testcase {
return $newvar;
}
public function test_xml_escape_simple_input_not_escaped() {
public function test_xml_escape_simple_input_not_escaped(): void {
$exporter = new qformat_xml();
$string = 'Nothing funny here. Even if we go to a café or to 日本.';
$this->assertEquals($string, $exporter->xml_escape($string));
}
public function test_xml_escape_html_wrapped_in_cdata() {
public function test_xml_escape_html_wrapped_in_cdata(): void {
$exporter = new qformat_xml();
$string = '<p>Nothing <b>funny<b> here. Even if we go to a café or to 日本.</p>';
$this->assertEquals('<![CDATA[' . $string . ']]>', $exporter->xml_escape($string));
}
public function test_xml_escape_script_tag_handled_ok() {
public function test_xml_escape_script_tag_handled_ok(): void {
$exporter = new qformat_xml();
$input = '<script><![CDATA[alert(1<2);]]></script>';
$expected = '<![CDATA[<script><![CDATA[alert(1<2);]]]]><![CDATA[></script>]]>';
@@ -138,7 +138,7 @@ class xmlformat_test extends \question_testcase {
$this->assertEquals($input, $parsed->xpath('//div')[0]);
}
public function test_xml_escape_code_that_looks_like_cdata_end_ok() {
public function test_xml_escape_code_that_looks_like_cdata_end_ok(): void {
$exporter = new qformat_xml();
$input = "if (x[[0]]>a) print('hah');";
$expected = "<![CDATA[if (x[[0]]]]><![CDATA[>a) print('hah');]]>";
@@ -149,7 +149,7 @@ class xmlformat_test extends \question_testcase {
$this->assertEquals($input, $parsed->xpath('//div')[0]);
}
public function test_write_hint_basic() {
public function test_write_hint_basic(): void {
$q = $this->make_test_question();
$q->contextid = \context_system::instance()->id;
$q->name = 'Short answer question';
@@ -179,7 +179,7 @@ class xmlformat_test extends \question_testcase {
$this->assertDoesNotMatchRegularExpression('|<options>|', $xml);
}
public function test_write_hint_with_parts() {
public function test_write_hint_with_parts(): void {
$q = $this->make_test_question();
$q->contextid = \context_system::instance()->id;
$q->name = 'Matching question';
@@ -219,7 +219,7 @@ class xmlformat_test extends \question_testcase {
$this->assertDoesNotMatchRegularExpression('|<options>|', $xml);
}
public function test_import_hints_no_parts() {
public function test_import_hints_no_parts(): void {
$xml = <<<END
<question>
<hint>
@@ -249,7 +249,7 @@ END;
$this->assertFalse(isset($qo->hintshownumcorrect));
}
public function test_import_hints_with_parts() {
public function test_import_hints_with_parts(): void {
$xml = <<<END
<question>
<hint>
@@ -279,7 +279,7 @@ END;
$this->assertEquals(array(0, 1), $qo->hintshownumcorrect);
}
public function test_import_no_hints_no_error() {
public function test_import_no_hints_no_error(): void {
$xml = <<<END
<question>
</question>
@@ -294,7 +294,7 @@ END;
$this->assertFalse(isset($qo->hint));
}
public function test_import_description() {
public function test_import_description(): void {
$xml = ' <question type="description">
<name>
<text>A description</text>
@@ -332,7 +332,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_description() {
public function test_export_description(): void {
$qdata = new \stdClass();
$qdata->id = 123;
$qdata->contextid = \context_system::instance()->id;
@@ -372,7 +372,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_essay_20() {
public function test_import_essay_20(): void {
$xml = ' <question type="essay">
<name>
<text>An essay</text>
@@ -426,7 +426,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_import_essay_21() {
public function test_import_essay_21(): void {
$xml = ' <question type="essay">
<name>
<text>An essay</text>
@@ -491,7 +491,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_import_essay_311() {
public function test_import_essay_311(): void {
$xml = ' <question type="essay">
<name>
<text>An essay</text>
@@ -560,7 +560,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_essay() {
public function test_export_essay(): void {
$qdata = new \stdClass();
$qdata->id = 123;
$qdata->contextid = \context_system::instance()->id;
@@ -630,7 +630,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_match_19() {
public function test_import_match_19(): void {
$xml = ' <question type="matching">
<name>
<text>Matching question</text>
@@ -732,7 +732,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_match() {
public function test_export_match(): void {
$qdata = new \stdClass();
$qdata->id = 123;
$qdata->contextid = \context_system::instance()->id;
@@ -857,7 +857,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_multichoice_19() {
public function test_import_multichoice_19(): void {
$xml = ' <question type="multichoice">
<name>
<text>Multiple choice question</text>
@@ -965,7 +965,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_multichoice() {
public function test_export_multichoice(): void {
$qdata = new \stdClass();
$qdata->id = 123;
$qdata->contextid = \context_system::instance()->id;
@@ -1074,7 +1074,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_numerical_19() {
public function test_import_numerical_19(): void {
$xml = ' <question type="numerical">
<name>
<text>Numerical question</text>
@@ -1140,7 +1140,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_numerical() {
public function test_export_numerical(): void {
question_bank::load_question_definition_classes('numerical');
$qdata = new \stdClass();
@@ -1215,7 +1215,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_shortanswer_19() {
public function test_import_shortanswer_19(): void {
$xml = ' <question type="shortanswer">
<name>
<text>Short answer question</text>
@@ -1274,7 +1274,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_shortanswer() {
public function test_export_shortanswer(): void {
$qdata = new \stdClass();
$qdata->id = 123;
$qdata->contextid = \context_system::instance()->id;
@@ -1346,7 +1346,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_truefalse_19() {
public function test_import_truefalse_19(): void {
$xml = ' <question type="truefalse">
<name>
<text>True false question</text>
@@ -1397,7 +1397,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_import_truefalse_with_idnumber() {
public function test_import_truefalse_with_idnumber(): void {
$xml = ' <question type="truefalse">
<name>
<text>True false question</text>
@@ -1450,7 +1450,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedq), $q);
}
public function test_export_truefalse() {
public function test_export_truefalse(): void {
$qdata = new \stdClass();
$qdata->id = 12;
$qdata->contextid = \context_system::instance()->id;
@@ -1510,7 +1510,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_export_truefalse_with_idnumber() {
public function test_export_truefalse_with_idnumber(): void {
$qdata = new \stdClass();
$qdata->id = 12;
$qdata->contextid = \context_system::instance()->id;
@@ -1570,7 +1570,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_multianswer() {
public function test_import_multianswer(): void {
$xml = ' <question type="cloze">
<name>
<text>Simple multianswer</text>
@@ -1679,7 +1679,7 @@ END;
$this->assert(new question_check_specified_fields_expectation($expectedqa), $q);
}
public function test_export_multianswer() {
public function test_export_multianswer(): void {
$qdata = \test_question_maker::get_question_data('multianswer', 'twosubq');
$qdata->contextid = \context_system::instance()->id;
$exporter = new qformat_xml();
@@ -1711,7 +1711,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_export_multianswer_withdollars() {
public function test_export_multianswer_withdollars(): void {
$qdata = \test_question_maker::get_question_data('multianswer', 'dollarsigns');
$qdata->contextid = \context_system::instance()->id;
$exporter = new qformat_xml();
@@ -1737,7 +1737,7 @@ END;
$this->assert_same_xml($expectedxml, $xml);
}
public function test_import_files_as_draft() {
public function test_import_files_as_draft(): void {
$this->resetAfterTest();
$this->setAdminUser();
@@ -1763,7 +1763,7 @@ END;
$this->assertEquals(6, $file->size);
}
public function test_import_truefalse_wih_files() {
public function test_import_truefalse_wih_files(): void {
$this->resetAfterTest();
$this->setAdminUser();
@@ -1810,7 +1810,7 @@ END;
$this->assertEquals(6, $file->size);
}
public function test_create_dummy_question() {
public function test_create_dummy_question(): void {
$testobject = new mock_qformat_xml();
$categoryname = 'name1';