L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81522 phpunit: Add missing void return type to all tests

Browse Source 
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-06-11 12:18:04 +02:00
parent db07c09afc
commit 1093256560
1360 changed files with 9928 additions and 9928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/tablelib_test.php
+17 -17
View File
@@ -127,7 +127,7 @@ class tablelib_test extends \advanced_testcase {
return $table;
}
public function test_empty_table() {
public function test_empty_table(): void {
$this->expectOutputRegex('/' . get_string('nothingtodisplay') . '/');
$this->run_table_test(
array('column1', 'column2'), // Columns.
@@ -141,7 +141,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_has_next_pagination() {
public function test_has_next_pagination(): void {
$data = $this->generate_data(11, 2);
$columns = $this->generate_columns(2);
@@ -162,7 +162,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_has_hide() {
public function test_has_hide(): void {
$data = $this->generate_data(11, 2);
$columns = $this->generate_columns(2);
@@ -183,7 +183,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_has_not_hide() {
public function test_has_not_hide(): void {
$data = $this->generate_data(11, 2);
$columns = $this->generate_columns(2);
@@ -207,7 +207,7 @@ class tablelib_test extends \advanced_testcase {
$this->assertStringNotContainsString(get_string('hide'), $output);
}
public function test_has_sort() {
public function test_has_sort(): void {
$data = $this->generate_data(11, 2);
$columns = $this->generate_columns(2);
@@ -228,7 +228,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_has_not_sort() {
public function test_has_not_sort(): void {
$data = $this->generate_data(11, 2);
$columns = $this->generate_columns(2);
@@ -252,7 +252,7 @@ class tablelib_test extends \advanced_testcase {
$this->assertStringNotContainsString(get_string('sortby'), $output);
}
public function test_has_not_next_pagination() {
public function test_has_not_next_pagination(): void {
$data = $this->generate_data(10, 2);
$columns = $this->generate_columns(2);
@@ -277,7 +277,7 @@ class tablelib_test extends \advanced_testcase {
$this->assertStringNotContainsString(get_string('next'), $output);
}
public function test_1_col() {
public function test_1_col(): void {
$data = $this->generate_data(100, 1);
$columns = $this->generate_columns(1);
@@ -297,7 +297,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_empty_rows() {
public function test_empty_rows(): void {
$data = $this->generate_data(1, 5);
$columns = $this->generate_columns(5);
@@ -318,7 +318,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_5_cols() {
public function test_5_cols(): void {
$data = $this->generate_data(100, 5);
$columns = $this->generate_columns(5);
@@ -338,7 +338,7 @@ class tablelib_test extends \advanced_testcase {
);
}
public function test_50_cols() {
public function test_50_cols(): void {
$data = $this->generate_data(100, 50);
$columns = $this->generate_columns(50);
@@ -379,7 +379,7 @@ class tablelib_test extends \advanced_testcase {
*
* @dataProvider fullname_column_provider
*/
public function test_fullname_column(string $format) {
public function test_fullname_column(string $format): void {
$this->resetAfterTest();
$this->setAdminUser();
@@ -399,7 +399,7 @@ class tablelib_test extends \advanced_testcase {
*
* @dataProvider fullname_column_provider
*/
public function test_fullname_column_prohibit_viewfullnames(string $format) {
public function test_fullname_column_prohibit_viewfullnames(string $format): void {
global $DB, $CFG;
$this->resetAfterTest();
@@ -419,7 +419,7 @@ class tablelib_test extends \advanced_testcase {
$this->assertStringContainsString(fullname($user, false), $table->format_row($user)['fullname']);
}
public function test_get_row_html() {
public function test_get_row_html(): void {
$data = $this->generate_data(1, 5);
$columns = $this->generate_columns(5);
$headers = $this->generate_headers(5);
@@ -436,7 +436,7 @@ class tablelib_test extends \advanced_testcase {
$this->assertMatchesRegularExpression('/<td class="cell c0"/', $row);
}
public function test_persistent_table() {
public function test_persistent_table(): void {
global $SESSION;
$data = $this->generate_data(5, 5);
@@ -592,7 +592,7 @@ class tablelib_test extends \advanced_testcase {
return $table;
}
public function test_can_be_reset() {
public function test_can_be_reset(): void {
// Table in its default state (as if seen for the first time), nothing to reset.
$table = $this->prepare_table_for_reset_test(uniqid('tablelib_test_'));
$table->setup();
@@ -689,7 +689,7 @@ class tablelib_test extends \advanced_testcase {
/**
* Test export in CSV format
*/
public function test_table_export() {
public function test_table_export(): void {
$table = new flexible_table('tablelib_test_export');
$table->define_baseurl('/invalid.php');
$table->define_columns(['c1', 'c2', 'c3']);