L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81522 phpunit: Add missing void return type to all tests

Browse Source 
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-06-11 12:18:04 +02:00
parent db07c09afc
commit 1093256560
1360 changed files with 9928 additions and 9928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/http_client_test.php
+12 -12
View File
@@ -75,7 +75,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_http_client_can_send_synchronously() {
public function test_http_client_can_send_synchronously(): void {
$testhtml = $this->getExternalTestFileUrl('/test.html');
$client = new \core\http_client(['handler' => new MockHandler([new Response()])]);
@@ -90,7 +90,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_http_client_has_options() {
public function test_http_client_has_options(): void {
$testhtml = $this->getExternalTestFileUrl('/test.html');
$client = new \core\http_client([
@@ -115,7 +115,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_http_client_can_modify_the_header_for_each_request() {
public function test_http_client_can_modify_the_header_for_each_request(): void {
$testhtml = $this->getExternalTestFileUrl('/test.html');
$mock = new MockHandler([new Response()]);
@@ -132,7 +132,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_can_unset_request_option_with_null() {
public function test_can_unset_request_option_with_null(): void {
$testhtml = $this->getExternalTestFileUrl('/test.html');
$mock = new MockHandler([new Response()]);
@@ -150,7 +150,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_basic_cookie_jar() {
public function test_basic_cookie_jar(): void {
$mock = new MockHandler([
new Response(200, ['Set-Cookie' => 'foo=bar']),
new Response()
@@ -167,7 +167,7 @@ class http_client_test extends \advanced_testcase {
*
* @covers \core\http_client
*/
public function test_shared_cookie_jar() {
public function test_shared_cookie_jar(): void {
$mock = new MockHandler([
new Response(200, ['Set-Cookie' => 'foo=bar']),
new Response()
@@ -184,7 +184,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\http_client
* @covers \core\local\guzzle\check_request
*/
public function test_guzzle_basics_with_security_helper() {
public function test_guzzle_basics_with_security_helper(): void {
$this->resetAfterTest();
// Test a request with a basic hostname filter applied.
@@ -229,7 +229,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\http_client
* @covers \core\local\guzzle\check_request
*/
public function test_http_client_proxy_bypass() {
public function test_http_client_proxy_bypass(): void {
$this->resetAfterTest();
global $CFG;
@@ -260,7 +260,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\http_client
* @covers \core\local\guzzle\redirect_middleware
*/
public function test_moodle_allow_redirects_can_be_true() {
public function test_moodle_allow_redirects_can_be_true(): void {
$testurl = $this->getExternalTestFileUrl('/test_redir.php');
$mock = new MockHandler([new Response(200, [], 'foo')]);
@@ -276,7 +276,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\http_client
* @covers \core\local\guzzle\redirect_middleware
*/
public function test_redirects_with_absolute_uri() {
public function test_redirects_with_absolute_uri(): void {
$testurl = $this->getExternalTestFileUrl('/test_redir.php');
$mock = new MockHandler([
@@ -297,7 +297,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\http_client
* @covers \core\local\guzzle\redirect_middleware
*/
public function test_redirects_with_relative_uri() {
public function test_redirects_with_relative_uri(): void {
$testurl = $this->getExternalTestFileUrl('/test_relative_redir.php');
$mock = new MockHandler([
@@ -369,7 +369,7 @@ class http_client_test extends \advanced_testcase {
* @covers \core\local\guzzle\cache_handler
* @covers \core\local\guzzle\cache_storage
*/
public function test_http_client_cache_item() {
public function test_http_client_cache_item(): void {
global $CFG, $USER;
$module = 'core_guzzle';
$cachedir = "$CFG->cachedir/$module/";