L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-81522 phpunit: Add missing void return type to all tests

Browse Source 
While this change is not 100% required now, it's good habit
and we are checking for it since Moodle 4.4.

All the changes in this commit have been applied automatically
using the moodle.PHPUnit.TestReturnType sniff and are, exclusively
adding the ": void" return types when missing.
This commit is contained in:
Eloy Lafuente (stronk7)
2024-06-11 12:18:04 +02:00
parent db07c09afc
commit 1093256560
1360 changed files with 9928 additions and 9928 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backup/controller/tests/controller_test.php
+8 -8
View File
@@ -76,7 +76,7 @@ class controller_test extends \advanced_testcase {
*
* @covers \restore_controller::get_copy
*/
public function test_restore_controller_get_copy() {
public function test_restore_controller_get_copy(): void {
$copydata = (object)["some" => "copydata"];
$rc = new \restore_controller(1729, $this->courseid, backup::INTERACTIVE_NO, backup::MODE_COPY,
$this->userid, backup::TARGET_NEW_COURSE, null, backup::RELEASESESSION_NO, $copydata);
@@ -89,7 +89,7 @@ class controller_test extends \advanced_testcase {
*
* @covers \restore_controller::__construct
*/
public function test_restore_controller_copy_without_copydata() {
public function test_restore_controller_copy_without_copydata(): void {
$this->expectException(\restore_controller_exception::class);
new \restore_controller(1729, $this->courseid, backup::INTERACTIVE_NO, backup::MODE_COPY,
@@ -99,7 +99,7 @@ class controller_test extends \advanced_testcase {
/*
* test base_setting class
*/
public function test_backup_controller() {
public function test_backup_controller(): void {
// Instantiate non interactive backup_controller
$bc = new mock_backup_controller(backup::TYPE_1ACTIVITY, $this->moduleid, backup::FORMAT_MOODLE,
backup::INTERACTIVE_NO, backup::MODE_GENERAL, $this->userid);
@@ -120,7 +120,7 @@ class controller_test extends \advanced_testcase {
$this->assertTrue($newbc instanceof backup_controller); // This means checksum and load worked ok
}
public function test_backup_controller_include_files() {
public function test_backup_controller_include_files(): void {
// A MODE_GENERAL controller - this should include files
$bc = new mock_backup_controller(backup::TYPE_1ACTIVITY, $this->moduleid, backup::FORMAT_MOODLE,
backup::INTERACTIVE_NO, backup::MODE_GENERAL, $this->userid);
@@ -142,7 +142,7 @@ class controller_test extends \advanced_testcase {
/**
* Test set kept roles method.
*/
public function test_backup_controller_set_kept_roles() {
public function test_backup_controller_set_kept_roles(): void {
$this->expectException(\backup_controller_exception::class);
// Set up controller as a non-copy operation.
@@ -155,7 +155,7 @@ class controller_test extends \advanced_testcase {
/**
* Tests the restore_controller.
*/
public function test_restore_controller_is_executing() {
public function test_restore_controller_is_executing(): void {
global $CFG;
// Make a backup.
@@ -202,7 +202,7 @@ class controller_test extends \advanced_testcase {
/**
* Test prepare copy method.
*/
public function test_restore_controller_prepare_copy() {
public function test_restore_controller_prepare_copy(): void {
$this->expectException(\restore_controller_exception::class);
global $CFG;
@@ -225,7 +225,7 @@ class controller_test extends \advanced_testcase {
/**
* Test restore of deadlock causing backup.
*/
public function test_restore_of_deadlock_causing_backup() {
public function test_restore_of_deadlock_causing_backup(): void {
global $USER, $CFG;
$this->preventResetByRollback();