L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-73485 phpunit: externallib, generator and filter tescase names

Browse Source 
All externallib_test, generator_test and filter_test classes:

- Namespaced with component[\level2-API]
- Moved to level2-API subdirectory when required.
- Fixed incorrect use statements with leading backslash.
- Changed code to point to global scope when needed.
- Fix some relative paths and comments here and there.
- All them passing individually.
- Complete runs passing too.

Special mention to tests under testing/tests:

1) The core_testing component doesn't exist.
2) But testing/tests are allowed because there is a suite pointing to it (phpunit.xml).
3) So, the only possible namespace for them is "core".
4) And to avoid problems with other core testcases (under lib/tests)
   they have been renamed to have testing_xxxx as prefix.

Finally, also modified calendar/tests/events/events_test.php because it uses
some renamed (core_calendar_externallib_testcase => \core_calendar\externallib_test)
classes.
This commit is contained in:
Eloy Lafuente (stronk7)
2022-01-21 19:48:23 +01:00
parent e63604fb6d
commit 100bc51f1d
85 changed files with 2339 additions and 2606 deletions
Download Patch File Download Diff File Expand all files Collapse all files
notes/tests/generator_test.php
+4 -4
View File
@@ -22,7 +22,7 @@
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
defined('MOODLE_INTERNAL') || die();
namespace core_notes;
/**
* Generator tests class.
@@ -31,7 +31,7 @@ defined('MOODLE_INTERNAL') || die();
* @copyright 2013 Ankit Agarwal
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class core_notes_generator_testcase extends advanced_testcase {
class generator_test extends \advanced_testcase {
/** Test create_instance method */
public function test_create_instance() {
@@ -65,7 +65,7 @@ class core_notes_generator_testcase extends advanced_testcase {
try {
$gen->create_instance(array('courseid' => 2));
$this->fail('A note should not be allowed to be created without associcated userid');
} catch (coding_exception $e) {
} catch (\coding_exception $e) {
$this->assertStringContainsString('Module generator requires $record->userid', $e->getMessage());
}
@@ -73,7 +73,7 @@ class core_notes_generator_testcase extends advanced_testcase {
try {
$gen->create_instance(array('userid' => 2));
$this->fail('A note should not be allowed to be created without associcated courseid');
} catch (coding_exception $e) {
} catch (\coding_exception $e) {
$this->assertStringContainsString('Module generator requires $record->courseid', $e->getMessage());
}
}