From 0fadf1ed19e8e4ea2c2bc2857d6ea3ffdabf4e8c Mon Sep 17 00:00:00 2001
From: ferranrecio <ferran@moodle.com>
Date: Fri, 6 Sep 2024 10:59:36 +0200
Subject: [PATCH] MDL-79020 core_courseformat: hide completion edit link in
 bulk edit

---
 .../local/content/cm/completion_dialog.mustache  |  2 +-
 .../tests/behat/coursepage_completion.feature    | 16 ++++++++++++++++
 2 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/course/format/templates/local/content/cm/completion_dialog.mustache b/course/format/templates/local/content/cm/completion_dialog.mustache
index 7dabcddc436..2cfa52ccc49 100644
--- a/course/format/templates/local/content/cm/completion_dialog.mustache
+++ b/course/format/templates/local/content/cm/completion_dialog.mustache
@@ -110,7 +110,7 @@
     {{! Show edit link to editing teachers. }}
     {{#editing}}
         {{#editurl}}
-            <div class="editcompletion border-top mt-3 pt-3">
+            <div class="editcompletion bulk-hidden border-top mt-3 pt-3">
                 <a href="{{editurl}}" class="btn btn-sm px-2 py-0">
                     {{#hasconditions}}{{#pix}} i/edit, core {{/pix}}{{#str}}editconditions, completion{{/str}}{{/hasconditions}}
                     {{^hasconditions}}{{#pix}} t/add, core {{/pix}}{{#str}}addconditions, completion{{/str}}{{/hasconditions}}
diff --git a/course/format/tests/behat/coursepage_completion.feature b/course/format/tests/behat/coursepage_completion.feature
index 263048c4095..a0b1cb21e3c 100644
--- a/course/format/tests/behat/coursepage_completion.feature
+++ b/course/format/tests/behat/coursepage_completion.feature
@@ -174,3 +174,19 @@ Feature: Course page activities completion
     # Student view.
     And I am on the "C1" "Course" page logged in as "student1"
     And "There are no completion conditions set for this activity." "text" should exist in the "Activity sample" "core_courseformat > Activity completion"
+
+  @javascript
+  Scenario: Completion edit button should be hidden in bulk editing
+    Given the following "activity" exists:
+      | activity       | assign          |
+      | name           | Activity sample |
+      | course         | C1              |
+      | completion     | 2               |
+      | completionview | 1               |
+    And I log in as "teacher1"
+    And I am on "C1" course homepage with editing mode on
+    And I click on "Completion" "button"
+    And "Edit conditions" "link" in the "Activity sample" "activity" should be visible
+    When I click on "Bulk actions" "button"
+    And I click on "Completion" "button"
+    Then "Edit conditions" "link" in the "Activity sample" "activity" should not be visible