From 6f6ea8c32d10c1683d5a9ba88fab3b223fc9429f Mon Sep 17 00:00:00 2001
From: "Eloy Lafuente (stronk7)" <stronk7@moodle.org>
Date: Wed, 3 Apr 2019 02:42:45 +0200
Subject: [PATCH] MDL-65250 core: Fix some undefined variables in compact()

Since PHP 7.3 they throw a PHP Notice.
---
 course/request.php                               | 2 +-
 mod/scorm/report/interactions/classes/report.php | 2 +-
 mod/scorm/report/objectives/classes/report.php   | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/course/request.php b/course/request.php
index 34d02d3385e..e330e1d9df3 100644
--- a/course/request.php
+++ b/course/request.php
@@ -53,7 +53,7 @@ require_capability('moodle/course:request', $context);
 
 // Set up the form.
 $data = course_request::prepare();
-$requestform = new course_request_form($url, compact('editoroptions'));
+$requestform = new course_request_form($url);
 $requestform->set_data($data);
 
 $strtitle = get_string('courserequest');
diff --git a/mod/scorm/report/interactions/classes/report.php b/mod/scorm/report/interactions/classes/report.php
index 33da5adcd7b..6613be489d5 100644
--- a/mod/scorm/report/interactions/classes/report.php
+++ b/mod/scorm/report/interactions/classes/report.php
@@ -643,7 +643,7 @@ class report extends \mod_scorm\report {
             }
             // Show preferences form irrespective of attempts are there to report or not.
             if (!$download) {
-                $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
+                $mform->set_data(compact('pagesize', 'attemptsmode'));
                 $mform->display();
             }
             if ($download == 'Excel' or $download == 'ODS') {
diff --git a/mod/scorm/report/objectives/classes/report.php b/mod/scorm/report/objectives/classes/report.php
index c65c032c3fc..ca31baf3df9 100644
--- a/mod/scorm/report/objectives/classes/report.php
+++ b/mod/scorm/report/objectives/classes/report.php
@@ -642,7 +642,7 @@ class report extends \mod_scorm\report {
             }
             // Show preferences form irrespective of attempts are there to report or not.
             if (!$download) {
-                $mform->set_data(compact('detailedrep', 'pagesize', 'attemptsmode'));
+                $mform->set_data(compact('pagesize', 'attemptsmode'));
                 $mform->display();
             }
             if ($download == 'Excel' or $download == 'ODS') {