diff --git a/admin/tests/behat/behat_admin.php b/admin/tests/behat/behat_admin.php index d8ec74c9c5a..04536bc6015 100644 --- a/admin/tests/behat/behat_admin.php +++ b/admin/tests/behat/behat_admin.php @@ -48,7 +48,6 @@ class behat_admin extends behat_base { * @param TableNode $table */ public function i_set_the_following_administration_settings_values(TableNode $table) { - if (!$data = $table->getRowsHash()) { return; } @@ -57,17 +56,12 @@ class behat_admin extends behat_base { // We expect admin block to be visible, otherwise go to homepage. if (!$this->getSession()->getPage()->find('css', '.block_settings')) { - $this->getSession()->visit($this->locate_path('/')); - $this->wait(self::get_timeout() * 1000, self::PAGE_READY_JS); + $this->execute('behat_forms::i_am_on_homepage'); } // Search by label. - $searchbox = $this->find_field(get_string('searchinsettings', 'admin')); - $searchbox->setValue($label); - $submitsearch = $this->find('css', 'form.adminsearchform input[type=submit]'); - $submitsearch->press(); - - $this->wait(self::get_timeout() * 1000, self::PAGE_READY_JS); + $this->execute('behat_forms::i_set_the_field_to', [get_string('searchinsettings', 'admin'), $label]); + $this->execute("behat_general::i_click_on_in_the", [get_string('search', 'admin'), 'button', '.block_settings', 'css_element']); // Admin settings does not use the same DOM structure than other moodle forms // but we also need to use lib/behat/form_field/* to deal with the different moodle form elements. @@ -83,35 +77,17 @@ class behat_admin extends behat_base { "@id=//span[contains(normalize-space(.), $label)]/preceding-sibling::label[1]/@for]"; $fieldnode = $this->find('xpath', $fieldxpath, $exception); - $formfieldtypenode = $this->find('xpath', $fieldxpath . "/ancestor::div[@class='form-setting']" . - "/child::div[contains(concat(' ', @class, ' '), ' form-')]/child::*/parent::div"); - } catch (ElementNotFoundException $e) { - // Multi element settings, interacting only the first one. $fieldxpath = "//*[label[normalize-space(.)= $label]|span[normalize-space(.)= $label]]/" . "ancestor::div[contains(concat(' ', normalize-space(@class), ' '), ' form-item ')]" . "/descendant::div[@class='form-group']/descendant::*[self::input | self::textarea | self::select]" . "[not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]"; $fieldnode = $this->find('xpath', $fieldxpath); - - // It is the same one that contains the type. - $formfieldtypenode = $fieldnode; } - // Getting the class which contains the field type. - $classes = explode(' ', $formfieldtypenode->getAttribute('class')); - foreach ($classes as $class) { - if (substr($class, 0, 5) == 'form-') { - $type = substr($class, 5); - } - } - - // Instantiating the appropiate field type. - $field = behat_field_manager::get_field_instance($type, $fieldnode, $this->getSession()); - $field->set_value($value); - - $this->find_button(get_string('savechanges'))->press(); + $this->execute('behat_forms::i_set_the_field_with_xpath_to', [$fieldxpath, $value]); + $this->execute("behat_general::i_click_on", [get_string('savechanges'), 'button']); } } diff --git a/theme/boost/tests/behat/behat_theme_boost_behat_admin.php b/theme/boost/tests/behat/behat_theme_boost_behat_admin.php index b75e4dbbd7c..dd0f3b40ab6 100644 --- a/theme/boost/tests/behat/behat_theme_boost_behat_admin.php +++ b/theme/boost/tests/behat/behat_theme_boost_behat_admin.php @@ -48,12 +48,8 @@ class behat_theme_boost_behat_admin extends behat_admin { $this->execute('behat_navigation::i_select_from_flat_navigation_drawer', [get_string('administrationsite')]); // Search by label. - $searchbox = $this->find_field(get_string('query', 'admin')); - $searchbox->setValue($label); - $submitsearch = $this->find('css', 'form input[type=submit][name=search]'); - $submitsearch->press(); - - $this->wait(self::get_timeout() * 1000, self::PAGE_READY_JS); + $this->execute('behat_forms::i_set_the_field_to', [get_string('query', 'admin'), $label]); + $this->execute("behat_general::i_click_on", [get_string('search', 'admin'), 'button']); // Admin settings does not use the same DOM structure than other moodle forms // but we also need to use lib/behat/form_field/* to deal with the different moodle form elements. @@ -69,11 +65,6 @@ class behat_theme_boost_behat_admin extends behat_admin { "[@id=//label[contains(normalize-space(.), $label)]/@for or " . "@id=//span[contains(normalize-space(.), $label)]/preceding-sibling::label[1]/@for]"; $fieldnode = $this->find('xpath', $fieldxpath, $exception); - - $formfieldtypenode = $this->find('xpath', $fieldxpath . - "/ancestor::div[contains(concat(' ', @class, ' '), ' form-setting ')]" . - "/child::div[contains(concat(' ', @class, ' '), ' form-')]/child::*/parent::div"); - } catch (ElementNotFoundException $e) { // Multi element settings, interacting only the first one. @@ -83,25 +74,11 @@ class behat_theme_boost_behat_admin extends behat_admin { "/descendant::*[self::input | self::textarea | self::select]" . "[not(./@type = 'submit' or ./@type = 'image' or ./@type = 'hidden')]"; $fieldnode = $this->find('xpath', $fieldxpath); - - // It is the same one that contains the type. - $formfieldtypenode = $fieldnode; } - // Getting the class which contains the field type. - $classes = explode(' ', $formfieldtypenode->getAttribute('class')); - $type = false; - foreach ($classes as $class) { - if (substr($class, 0, 5) == 'form-') { - $type = substr($class, 5); - } - } + $this->execute('behat_forms::i_set_the_field_with_xpath_to', [$fieldxpath, $value]); - // Instantiating the appropiate field type. - $field = behat_field_manager::get_field_instance($type, $fieldnode, $this->getSession()); - $field->set_value($value); - - $this->find_button(get_string('savechanges'))->press(); + $this->execute("behat_general::i_click_on", [get_string('savechanges'), 'button']); } }