L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-66394 analytics: Extra GC during analysis

Browse Source 
(backport of MDL-66234)
This commit is contained in:
David Monllaó
2019-09-24 14:08:24 +02:00
committed by Eloy Lafuente (stronk7)
parent 26c79027ff
commit 0a397e3fd2
5 changed files with 21 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
analytics/classes/analysis.php
+9 -1
View File
@@ -138,6 +138,9 @@ class analysis {
}
}
}
// Force GC to clean up the indicator instances used during the last iteration.
$this->analyser->instantiate_indicators();
}
/**
@@ -474,6 +477,11 @@ class analysis {
list($samplesfeatures, $newindicatorcalculations, $indicatornotnulls) = $rangeindicator->calculate($sampleids,
$this->analyser->get_samples_origin(), $range['start'], $range['end'], $prevcalculations);
// Free memory ASAP.
unset($rangeindicator);
gc_collect_cycles();
gc_mem_caches();
// Copy the features data to the dataset.
foreach ($samplesfeatures as $analysersampleid => $features) {
@@ -503,7 +511,7 @@ class analysis {
$indcalc->endtime = $range['end'];
$indcalc->sampleid = $sampleid;
$indcalc->sampleorigin = $this->analyser->get_samples_origin();
$indcalc->indicator = $rangeindicator->get_id();
$indcalc->indicator = $indicator->get_id();
$indcalc->value = $calculatedvalue;
$indcalc->timecreated = $timecreated;
$newcalculations[] = $indcalc;