From 92e6e128ff76ee6677c6c5724a9d451587658af0 Mon Sep 17 00:00:00 2001
From: M Kassaei <m.kassaei@open.ac.uk>
Date: Fri, 5 Aug 2011 09:04:48 +0100
Subject: [PATCH] MDL-27631 question bank Show question text in the question
 list when top level category is used

---
 mod/quiz/editlib.php |  7 +++----
 question/editlib.php | 12 ++++++------
 2 files changed, 9 insertions(+), 10 deletions(-)

diff --git a/mod/quiz/editlib.php b/mod/quiz/editlib.php
index 43dffccf09b..a6bc9883bd0 100644
--- a/mod/quiz/editlib.php
+++ b/mod/quiz/editlib.php
@@ -1183,15 +1183,14 @@ class quiz_question_bank_view extends question_bank_view {
         echo '</span></div></div>';
     }
 
-    protected function display_options($recurse = 1, $showhidden = false,
-            $showquestiontext = false) {
+    protected function display_options($recurse, $showhidden, $showquestiontext) {
         echo '<form method="get" action="edit.php" id="displayoptions">';
         echo "<fieldset class='invisiblefieldset'>";
         echo html_writer::input_hidden_params($this->baseurl,
                 array('recurse', 'showhidden', 'showquestiontext'));
-        $this->display_category_form_checkbox('recurse',
+        $this->display_category_form_checkbox('recurse', $recurse,
                 get_string('includesubcategories', 'question'));
-        $this->display_category_form_checkbox('showhidden',
+        $this->display_category_form_checkbox('showhidden', $showhidden,
                 get_string('showhidden', 'question'));
         echo '<noscript><div class="centerpara"><input type="submit" value="' .
                 get_string('go') . '" />';
diff --git a/question/editlib.php b/question/editlib.php
index 27f74a69f8d..89bba585eb1 100644
--- a/question/editlib.php
+++ b/question/editlib.php
@@ -1246,13 +1246,13 @@ class question_bank_view {
         echo "</div>\n";
     }
 
-    protected function display_options($recurse = 1, $showhidden = false, $showquestiontext = false) {
+    protected function display_options($recurse, $showhidden, $showquestiontext) {
         echo '<form method="get" action="edit.php" id="displayoptions">';
         echo "<fieldset class='invisiblefieldset'>";
         echo html_writer::input_hidden_params($this->baseurl, array('recurse', 'showhidden', 'showquestiontext'));
-        $this->display_category_form_checkbox('recurse', get_string('includesubcategories', 'question'));
-        $this->display_category_form_checkbox('showhidden', get_string('showhidden', 'question'));
-        $this->display_category_form_checkbox('qbshowtext', get_string('showquestiontext', 'question'));
+        $this->display_category_form_checkbox('recurse', $recurse, get_string('includesubcategories', 'question'));
+        $this->display_category_form_checkbox('showhidden', $showhidden, get_string('showhidden', 'question'));
+        $this->display_category_form_checkbox('qbshowtext', $showquestiontext, get_string('showquestiontext', 'question'));
         echo '<noscript><div class="centerpara"><input type="submit" value="'. get_string('go') .'" />';
         echo '</div></noscript></fieldset></form>';
     }
@@ -1260,10 +1260,10 @@ class question_bank_view {
     /**
      * Print a single option checkbox. Used by the preceeding.
      */
-    protected function display_category_form_checkbox($name, $label) {
+    protected function display_category_form_checkbox($name, $value, $label) {
         echo '<div><input type="hidden" id="' . $name . '_off" name="' . $name . '" value="0" />';
         echo '<input type="checkbox" id="' . $name . '_on" name="' . $name . '" value="1"';
-        if (optional_param($name, false, PARAM_BOOL)) {
+        if ($value) {
             echo ' checked="checked"';
         }
         echo ' onchange="getElementById(\'displayoptions\').submit(); return true;" />';