L-electron-Rare/moodle
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

MDL-77237 core: Suppress debugging during capabilities cleanup

Browse Source 
To prevent the debugging messages from appearing during the upgrade,
I set a flag to hide them.

For the test file, I adjusted the parameters in
the unassign_capability() function, which seemed to be using
the parameter intended for assign_capability().
This commit is contained in:
meirzamoodle
2025-07-15 14:36:26 +07:00
parent ce34e8ff08
commit 07af6ccc73
3 changed files with 46 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/tests/accesslib_test.php
+25 -3
View File
@@ -2247,7 +2247,7 @@ final class accesslib_test extends advanced_testcase {
$this->expectException('coding_exception');
$this->expectExceptionMessage("Capability '{$capability}' was not found! This has to be fixed in code.");
unassign_capability($capability, CAP_ALLOW, $teacherrole->id, $coursecontext);
unassign_capability($capability, $teacherrole->id, $coursecontext);
}
/**
@@ -3596,10 +3596,10 @@ final class accesslib_test extends advanced_testcase {
$rc = $DB->get_record('role_capabilities', array('contextid'=>$frontpagecontext->id, 'roleid'=>$allroles['teacher'], 'capability'=>'moodle/site:accessallgroups'));
$this->assertFalse($rc);
assign_capability('moodle/site:accessallgroups', CAP_ALLOW, $allroles['teacher'], $frontpagecontext);
unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext, true);
unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext);
$rc = $DB->get_record('role_capabilities', array('contextid'=>$frontpagecontext->id, 'roleid'=>$allroles['teacher'], 'capability'=>'moodle/site:accessallgroups'));
$this->assertFalse($rc);
unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext->id, true);
unassign_capability('moodle/site:accessallgroups', $allroles['teacher'], $frontpagecontext->id);
unset($rc);
accesslib_clear_all_caches_for_unit_testing(); // Must be done after assign_capability().
@@ -5291,6 +5291,28 @@ final class accesslib_test extends advanced_testcase {
$filtercontext = context_helper::get_navigation_filter_context($coursecontext);
$this->assertInstanceOf('\context_system', $filtercontext);
}
/**
* Test get_deprecated_capability_info() debugging messages.
*
* @covers ::get_deprecated_capability_info
*/
public function test_get_deprecated_capability_info_debugging(): void {
$this->resetAfterTest();
$course = $this->getDataGenerator()->create_course();
$this->getDataGenerator()->create_and_enrol($course);
$this->setup_fake_plugin('access');
// Debugging messages should not be called with valid capability.
get_capability_info('fake/access:existingcapability');
$this->assertDebuggingNotCalled();
// Debugging messages should be called with invalid capability.
get_capability_info('fake/access:fakecapability');
$this->assertDebuggingCalled("The capability 'fake/access:fakecapability' is"
. " deprecated.This capability should not be used anymore.");
// Debugging messages should not be called with invalid capability with suppression param supplied.
get_capability_info('fake/access:fakecapability', false);
$this->assertDebuggingNotCalled();
}
}
/**