From 028f587670d12f6aca0330b12646e1c62143d487 Mon Sep 17 00:00:00 2001 From: Mark Nielsen Date: Fri, 2 Jun 2017 09:27:48 -0700 Subject: [PATCH 1/2] MDL-59091 behat: Properly propagate gherkinlint exit code --- Gruntfile.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gruntfile.js b/Gruntfile.js index 4cb9e9ebbd9..5f2302e4562 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -338,7 +338,7 @@ module.exports = function(grunt) { opts: {stdio: 'inherit', env: process.env} }, function(error, result, code) { // Propagate the exit code. - done(code); + done(code === 0); }); }; From 4f66cd826f38aa41f0c9e3cf071078d550358700 Mon Sep 17 00:00:00 2001 From: Mark Nielsen Date: Fri, 2 Jun 2017 09:31:40 -0700 Subject: [PATCH 2/2] MDL-59091 behat: Fix gherkinlint errors Just whitespace problems. --- mod/data/tests/behat/completion_condition_entries.feature | 2 +- mod/quiz/tests/behat/editing_remove_multiple_questions.feature | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/mod/data/tests/behat/completion_condition_entries.feature b/mod/data/tests/behat/completion_condition_entries.feature index 252b2474ef3..d9da1db9110 100644 --- a/mod/data/tests/behat/completion_condition_entries.feature +++ b/mod/data/tests/behat/completion_condition_entries.feature @@ -4,7 +4,7 @@ Feature: Set entries required as a completion condition for a data item As a teacher I need to set entries required to mark the database activity as completed -Scenario: Two entries required to complete the activity + Scenario: Two entries required to complete the activity Given the following "users" exist: | username | firstname | lastname | email | | student1 | Student | 1 | student1@example.com | diff --git a/mod/quiz/tests/behat/editing_remove_multiple_questions.feature b/mod/quiz/tests/behat/editing_remove_multiple_questions.feature index 984123ef9b5..7d5c9be341d 100644 --- a/mod/quiz/tests/behat/editing_remove_multiple_questions.feature +++ b/mod/quiz/tests/behat/editing_remove_multiple_questions.feature @@ -167,4 +167,3 @@ Feature: Edit quiz page - remove multiple questions When I click on "Deselect all" "link" Then the field "selectquestion-3" matches value "0" -