From 07091e866d02bf536debb29328993363984f0568 Mon Sep 17 00:00:00 2001 From: Shamim Rezaie Date: Wed, 8 Apr 2020 11:32:36 +1000 Subject: [PATCH] MDL-68148 user: remove the noscript tag The submit button remains deactive if js is disabled. So having a noscript tag to output a submit button here does not make sense. --- user/index.php | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/user/index.php b/user/index.php index 87e18a0bd9f..746cec292db 100644 --- a/user/index.php +++ b/user/index.php @@ -339,15 +339,12 @@ if ($bulkoperations) { } } - echo html_writer::tag('div', html_writer::tag('label', get_string("withselectedusers"), - array('for' => 'formactionid', 'class' => 'col-form-label d-inline')) . - html_writer::select($displaylist, 'formaction', '', array('' => 'choosedots'), array('id' => 'formactionid')), - array('class' => 'ml-2')); + $label = html_writer::tag('label', get_string("withselectedusers"), + ['for' => 'formactionid', 'class' => 'col-form-label d-inline']); + $select = html_writer::select($displaylist, 'formaction', '', ['' => 'choosedots'], ['id' => 'formactionid']); + echo html_writer::tag('div', $label . $select, ['class' => 'ml-2']); - echo ''; - echo ''; + echo ''; echo ''; echo '';