diff --git a/lib/blocklib.php b/lib/blocklib.php index f7ab795fae7..54f08a8c8a2 100644 --- a/lib/blocklib.php +++ b/lib/blocklib.php @@ -341,7 +341,7 @@ class block_manager { * output the blocks anyway, so we are not doing wasted effort.) * * @param string $region a block region that exists on this page. - * @param object $output a core_renderer. normally the global $OUTPUT. + * @param core_renderer $output a core_renderer. normally the global $OUTPUT. * @return boolean Whether there is anything in this region. */ public function region_has_content($region, $output) { diff --git a/lib/outputrenderers.php b/lib/outputrenderers.php index 20fc0f4bfdd..55525f58731 100644 --- a/lib/outputrenderers.php +++ b/lib/outputrenderers.php @@ -921,7 +921,7 @@ class core_renderer extends renderer_base { $functioncalled = true; $courseformat = course_get_format($this->page->course); if (($obj = $courseformat->course_content_header()) !== null) { - return $courseformat->get_renderer($this->page)->render($obj); + return html_writer::div($courseformat->get_renderer($this->page)->render($obj), 'course-content-header'); } return ''; } @@ -948,7 +948,7 @@ class core_renderer extends renderer_base { require_once($CFG->dirroot.'/course/lib.php'); $courseformat = course_get_format($this->page->course); if (($obj = $courseformat->course_content_footer()) !== null) { - return $courseformat->get_renderer($this->page)->render($obj); + return html_writer::div($courseformat->get_renderer($this->page)->render($obj), 'course-content-footer'); } return ''; } @@ -2676,10 +2676,13 @@ EOD; */ public function navbar() { $items = $this->page->navbar->get_items(); + $itemcount = count($items); + if ($itemcount === 0) { + return ''; + } $htmlblocks = array(); // Iterate the navarray and display each node - $itemcount = count($items); $separator = get_separator(); for ($i=0;$i < $itemcount;$i++) { $item = $items[$i]; @@ -2828,7 +2831,7 @@ EOD; $jscode = "(function(){{$jscode}})"; $this->page->requires->yui_module('node-menunav', $jscode); // Build the root nodes as required by YUI - $content = html_writer::start_tag('div', array('id'=>'custom_menu_'.$menucount, 'class'=>'yui3-menu yui3-menu-horizontal javascript-disabled')); + $content = html_writer::start_tag('div', array('id'=>'custom_menu_'.$menucount, 'class'=>'yui3-menu yui3-menu-horizontal javascript-disabled custom-menu')); $content .= html_writer::start_tag('div', array('class'=>'yui3-menu-content')); $content .= html_writer::start_tag('ul'); // Render each child diff --git a/lib/pagelib.php b/lib/pagelib.php index 1f80e39c4aa..19940fb2cf2 100644 --- a/lib/pagelib.php +++ b/lib/pagelib.php @@ -51,7 +51,7 @@ defined('MOODLE_INTERNAL') || die(); * the forum or quiz table) that this page belongs to. Will be null * if this page is not within a module. * @property-read array $alternativeversions Mime type => object with ->url and ->title. - * @property-read blocks_manager $blocks The blocks manager object for this page. + * @property-read block_manager $blocks The blocks manager object for this page. * @property-read array $blockmanipulations * @property-read string $bodyclasses A string to use within the class attribute on the body tag. * @property-read string $bodyid A string to use as the id of the body tag. diff --git a/lib/weblib.php b/lib/weblib.php index 1985b7ec7f7..933356710f0 100644 --- a/lib/weblib.php +++ b/lib/weblib.php @@ -909,22 +909,39 @@ function close_window($delay = 0, $reloadopener = false) { * @return string The link to user documentation for this current page */ function page_doc_link($text='') { - global $CFG, $PAGE, $OUTPUT; - - if (empty($CFG->docroot) || during_initial_install()) { - return ''; - } - if (!has_capability('moodle/site:doclinks', $PAGE->context)) { - return ''; - } - - $path = $PAGE->docspath; + global $OUTPUT, $PAGE; + $path = page_get_doc_link_path($PAGE); if (!$path) { return ''; } return $OUTPUT->doc_link($path, $text); } +/** + * Returns the path to use when constructing a link to the docs. + * + * @since 2.5.1 2.6 + * @global stdClass $CFG + * @param moodle_page $page + * @return string + */ +function page_get_doc_link_path(moodle_page $page) { + global $CFG; + + if (empty($CFG->docroot) || during_initial_install()) { + return ''; + } + if (!has_capability('moodle/site:doclinks', $page->context)) { + return ''; + } + + $path = $page->docspath; + if (!$path) { + return ''; + } + return $path; +} + /** * Validates an email to make sure it makes sense.