From 05fca85d8e28539efbe36a839ba28dc41c142024 Mon Sep 17 00:00:00 2001
From: Andrew Nicols <andrew@nicols.co.uk>
Date: Sat, 23 Jan 2021 20:43:20 +0800
Subject: [PATCH] MDL-66979 behat: Warn about old behat.yml file location

---
 admin/tool/behat/lang/en/tool_behat.php | 1 +
 lib/behat/classes/behat_command.php     | 6 +++++-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/admin/tool/behat/lang/en/tool_behat.php b/admin/tool/behat/lang/en/tool_behat.php
index eea7b519d98..01c607d11dd 100644
--- a/admin/tool/behat/lang/en/tool_behat.php
+++ b/admin/tool/behat/lang/en/tool_behat.php
@@ -46,6 +46,7 @@ $string['stepsdefinitionstype'] = 'Type';
 $string['theninfo'] = 'Then. Checkings to ensure the outcomes are the expected ones';
 $string['unknownexceptioninfo'] = 'There was a problem with Selenium or your browser. Please ensure you are using the latest version of Selenium. Error:';
 $string['viewsteps'] = 'Filter';
+$string['warndirrootconfigfound'] = 'A configuration file was found at {$a}. This file is not automatically updated and may become stale. We recommend removing this file.';
 $string['wheninfo'] = 'When. Action that provokes an event';
 $string['wrongbehatsetup'] = 'Something is wrong with the behat setup and so step definitions cannot be listed: <b>{$a->errormsg}</b><br/><br/>Please check:<ul>
 <li>$CFG->behat_dataroot, $CFG->behat_prefix and $CFG->behat_wwwroot are set in config.php with different values from $CFG->dataroot, $CFG->prefix and $CFG->wwwroot.</li>
diff --git a/lib/behat/classes/behat_command.php b/lib/behat/classes/behat_command.php
index 4adc6275ee3..64ce8f6de77 100644
--- a/lib/behat/classes/behat_command.php
+++ b/lib/behat/classes/behat_command.php
@@ -179,7 +179,11 @@ class behat_command {
         }
 
         // Behat test command.
-        list($output, $code) = self::run(' --help');
+        $dirrootconfigpath = $CFG->dirroot . DIRECTORY_SEPARATOR . 'behat.yml';
+        if (file_exists($dirrootconfigpath)) {
+            self::output_msg(get_string('warndirrootconfigfound', 'tool_behat', $dirrootconfigpath));
+        }
+        list($output, $code) = self::run(" --help");
 
         if ($code != 0) {