From 05a970d3beecf8bea6ee03be52705b665cbb152e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20S=CC=8Ckoda?= Date: Tue, 9 Jul 2013 14:31:39 +0200 Subject: [PATCH] MDL-39846 add logging TODOs --- lib/classes/event/base.php | 8 ++++++++ lib/classes/event/role_assigned.php | 5 +++-- lib/classes/event/role_unassigned.php | 5 +++-- 3 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/classes/event/base.php b/lib/classes/event/base.php index 53faf521219..87764c2a057 100644 --- a/lib/classes/event/base.php +++ b/lib/classes/event/base.php @@ -205,6 +205,8 @@ abstract class base { * 1/ crud - letter [crud] * 2/ level - number 1...100 * + * TODO: MDL-37658 + * * Optionally validate $this->data['extra']. * * @return void @@ -216,6 +218,8 @@ abstract class base { * * Override in subclass, we can not make it static and abstract at the same time. * + * TODO: MDL-37658 + * * @return string|\lang_string */ public static function get_name() { @@ -230,6 +234,8 @@ abstract class base { /** * Returns localised description of what happened. * + * TODO: MDL-37658 + * * @return string|\lang_string */ public function get_description() { @@ -328,6 +334,8 @@ abstract class base { /** * Return auxiliary data that was stored in logs. * + * TODO: MDL-37658 + * * @return array the format is standardised by logging API */ public function get_logdata() { diff --git a/lib/classes/event/role_assigned.php b/lib/classes/event/role_assigned.php index 67e2cbe7804..3942c777bfb 100644 --- a/lib/classes/event/role_assigned.php +++ b/lib/classes/event/role_assigned.php @@ -27,6 +27,7 @@ namespace core\event; class role_assigned extends base { protected function init() { $this->data['crud'] = 'c'; + // TODO: MDL-37658 set level $this->data['level'] = 50; } @@ -36,7 +37,7 @@ class role_assigned extends base { * @return string|\lang_string */ public static function get_name() { - //TODO: localise + //TODO: MDL-37658 localise return 'Role assigned'; } @@ -46,7 +47,7 @@ class role_assigned extends base { * @return string|\lang_string */ public function get_description() { - //TODO: localise + //TODO: MDL-37658 localise return 'Role '.$this->objectid.' was assigned to user '.$this->relateduserid.' in context '.$this->contextid; } diff --git a/lib/classes/event/role_unassigned.php b/lib/classes/event/role_unassigned.php index bcfc1cdcf2c..942e58abe0f 100644 --- a/lib/classes/event/role_unassigned.php +++ b/lib/classes/event/role_unassigned.php @@ -27,6 +27,7 @@ namespace core\event; class role_unassigned extends base { protected function init() { $this->data['crud'] = 'd'; + // TODO: MDL-37658 set level $this->data['level'] = 50; } @@ -36,7 +37,7 @@ class role_unassigned extends base { * @return string|\lang_string */ public static function get_name() { - //TODO: localise + //TODO: MDL-37658 localise return 'Role unassigned'; } @@ -46,7 +47,7 @@ class role_unassigned extends base { * @return string|\lang_string */ public function get_description() { - //TODO: localise + //TODO: MDL-37658 localise return 'Role '.$this->objectid.'was unassigned from user '.$this->relateduserid.' in context '.$this->contextid; }