diff --git a/admin/health.php b/admin/health.php index d6877e0c908..10955ae8705 100644 --- a/admin/health.php +++ b/admin/health.php @@ -7,7 +7,8 @@ define('SEVERITY_SIGNIFICANT', 'significant'); define('SEVERITY_CRITICAL', 'critical'); - $resetsesserrorcounter = optional_param( 'resetsesserrorcounter' ); + $resetsesserrorcounter = optional_param('resetsesserrorcounter', 0, PARAM_BOOL); + $solution = optional_param('solution', 0, PARAM_SAFEDIR); //in fact it is class name alhanumeric and _ require_login(); if (!isadmin()) { @@ -83,9 +84,7 @@ dd.solution li { STYLES; - $solution = optional_param('solution', NULL); - - if(!empty($solution) && class_exists($solution)) { + if(strpos($solution, 'problem_') === 0 && class_exists($solution)) { health_print_solution($solution); } else { diff --git a/admin/index.php b/admin/index.php index d0a7a0f54de..2967841e156 100644 --- a/admin/index.php +++ b/admin/index.php @@ -1,23 +1,23 @@ dirroot/lib/adminlib.php"); // Contains various admin-only functions + require_once('../config.php'); + include_once($CFG->dirroot.'/lib/adminlib.php'); // Contains various admin-only functions - $id = optional_param('id', '', PARAM_ALPHANUM); - $confirmupgrade = optional_param('confirmupgrade',''); + $id = optional_param('id', '', PARAM_ALPHANUM); + $confirmupgrade = optional_param('confirmupgrade', 0, PARAM_BOOL); /// Check that PHP is of a sufficient version - if (!check_php_version("4.1.0")) { - $version = phpversion(); - print_heading("Sorry, Moodle requires PHP 4.1.0 or later (currently using version $version)"); + if (!check_php_version("4.1.0")) { //TODO: should we bump it up to 4.3.0?? + $phpversion = phpversion(); + print_heading("Sorry, Moodle requires PHP 4.1.0 or later (currently using version $phpversion)"); die; } diff --git a/admin/innodb.php b/admin/innodb.php index 613b59cf988..e5cd323387b 100644 --- a/admin/innodb.php +++ b/admin/innodb.php @@ -1,6 +1,8 @@ diff --git a/admin/lang.php b/admin/lang.php index 718c6803596..c87caf31255 100644 --- a/admin/lang.php +++ b/admin/lang.php @@ -1,8 +1,8 @@