From 03c7f3dc87efbf8b7db01e1f3b8a2fdc984c3f4c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Mudr=C3=A1k?= Date: Thu, 30 Jun 2022 22:10:57 +0200 Subject: [PATCH] MDL-75008 lang: Use the fixed strings in Behat scenario files --- .../tests/behat/bulk_edit_activity_completion.feature | 6 +++--- completion/tests/behat/default_activity_completion.feature | 4 ++-- course/tests/behat/activities_edit_completion.feature | 2 +- mod/wiki/tests/behat/wiki_activity_completion.feature | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/completion/tests/behat/bulk_edit_activity_completion.feature b/completion/tests/behat/bulk_edit_activity_completion.feature index 4d72d35b169..7911fbf11a9 100644 --- a/completion/tests/behat/bulk_edit_activity_completion.feature +++ b/completion/tests/behat/bulk_edit_activity_completion.feature @@ -39,7 +39,7 @@ Feature: Allow teachers to bulk edit activity completion rules in a course. And I click on "Edit" "button" And I should see "Completion tracking" And I should see "The changes will affect the following 2 activities or resources:" - And I should see "Student must submit to this activity to complete it" + And I should see "Student must make a submission" And I select "Show activity as complete when conditions are met" from the "completion" singleselect And I click on "completionview" "checkbox" And I click on "completionusegrade" "checkbox" @@ -49,10 +49,10 @@ Feature: Allow teachers to bulk edit activity completion rules in a course. And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" And I should see "Student must view this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" And I should see "Student must receive a grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" - And I should see "Student must submit to this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" + And I should see "Student must make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment one']]" "xpath_element" And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" And I should see "Student must view this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" And I should see "Student must receive a grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" - And I should see "Student must submit to this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" + And I should see "Student must make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Test assignment two']]" "xpath_element" diff --git a/completion/tests/behat/default_activity_completion.feature b/completion/tests/behat/default_activity_completion.feature index cc322753ef0..f397044ccfd 100644 --- a/completion/tests/behat/default_activity_completion.feature +++ b/completion/tests/behat/default_activity_completion.feature @@ -35,7 +35,7 @@ Feature: Allow teachers to edit the default activity completion rules in a cours And I click on "Edit" "button" And I should see "Completion tracking" And I should see "The changes will affect the following 1 activities or resources:" - And I should see "Student must submit to this activity to complete it" + And I should see "Student must make a submission" And I set the following fields to these values: | completion | Show activity as complete when conditions are met| | completionview | 1 | @@ -46,5 +46,5 @@ Feature: Allow teachers to edit the default activity completion rules in a cours And I should see "With conditions" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" And I should see "Student must view this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" And I should see "Student must receive a grade to complete this activity" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" - And I should see "Student must submit to this activity to complete it" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" + And I should see "Student must make a submission" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" And I should not see "Completion expected on" in the "//div[contains(concat(' ', normalize-space(@class), ' '), ' row ')][.//*[text() = 'Assignments']]" "xpath_element" diff --git a/course/tests/behat/activities_edit_completion.feature b/course/tests/behat/activities_edit_completion.feature index d190a4db554..6816c546293 100644 --- a/course/tests/behat/activities_edit_completion.feature +++ b/course/tests/behat/activities_edit_completion.feature @@ -29,7 +29,7 @@ Feature: Edit completion settings of an activity Given I am on the TestPage "Page Activity" page logged in as admin When I am on the TestPage "Page Activity editing" page And I expand all fieldsets - And I press "Unlock completion options" + And I press "Unlock completion settings" Then I should see "Completion options unlocked" And I set the field "Completion tracking" to "Students can manually mark the activity as completed" And I press "Save and display" diff --git a/mod/wiki/tests/behat/wiki_activity_completion.feature b/mod/wiki/tests/behat/wiki_activity_completion.feature index e4eb48bd38a..517ed33b31f 100644 --- a/mod/wiki/tests/behat/wiki_activity_completion.feature +++ b/mod/wiki/tests/behat/wiki_activity_completion.feature @@ -51,7 +51,7 @@ Feature: View activity completion information in the Wiki activity Given I am on the "Music history" "wiki activity" page logged in as teacher1 And I am on the "Music history" "wiki activity editing" page And I expand all fieldsets - And I press "Unlock completion options" + And I press "Unlock completion settings" And I set the field "Completion tracking" to "Students can manually mark the activity as completed" And I press "Save and display" # Teacher view.