From 0074ab9cefe00cf10ce8d232df2146d6b06b72bd Mon Sep 17 00:00:00 2001
From: nicolasconnault <nicolasconnault>
Date: Thu, 7 May 2009 07:52:10 +0000
Subject: [PATCH] MDL-12444 Removed aggregationview preference from category
 edit form

---
 grade/edit/tree/category.php      |  9 ---------
 grade/edit/tree/category_form.php | 13 -------------
 2 files changed, 22 deletions(-)

diff --git a/grade/edit/tree/category.php b/grade/edit/tree/category.php
index a0cbf5f3b1b..15da050e7b3 100644
--- a/grade/edit/tree/category.php
+++ b/grade/edit/tree/category.php
@@ -53,8 +53,6 @@ if ($id) {
     }
     $grade_category->apply_forced_settings();
     $category = $grade_category->get_record_data();
-    // Get Category preferences
-    $category->pref_aggregationview = grade_report::get_pref('aggregationview', $id);
     // set parent
     $category->parentcategory = $grade_category->parent;
     $grade_item = $grade_category->load_grade_item();
@@ -177,13 +175,6 @@ if ($mform->is_cancelled()) {
 
     $grade_item->update(); // We don't need to insert it, it's already created when the category is created
 
-    // Handle user preferences
-    if (isset($data->pref_aggregationview)) {
-        if (!grade_report::set_pref('aggregationview', $data->pref_aggregationview, $grade_category->id)) {
-            error("Could not set preference aggregationview to $value for this grade category");
-        }
-    }
-
     // set parent if needed
     if (isset($data->parentcategory)) {
         $grade_category->set_parent($data->parentcategory, 'gradebook');
diff --git a/grade/edit/tree/category_form.php b/grade/edit/tree/category_form.php
index e1896867ab4..e464b0b58b8 100644
--- a/grade/edit/tree/category_form.php
+++ b/grade/edit/tree/category_form.php
@@ -224,19 +224,6 @@ class edit_category_form extends moodleform {
             $mform->addElement('static', 'currentparentaggregation', get_string('currentparentaggregation', 'grades'));
         }
 
-/// user preferences
-        $mform->addElement('header', 'headerpreferences', get_string('myreportpreferences', 'grades'));
-        $options = array(GRADE_REPORT_PREFERENCE_DEFAULT => get_string('default', 'grades'),
-                         GRADE_REPORT_AGGREGATION_VIEW_FULL => get_string('fullmode', 'grades'),
-                         GRADE_REPORT_AGGREGATION_VIEW_AGGREGATES_ONLY => get_string('aggregatesonly', 'grades'),
-                         GRADE_REPORT_AGGREGATION_VIEW_GRADES_ONLY => get_string('gradesonly', 'grades'));
-        $label = get_string('aggregationview', 'grades') . ' (' . get_string('default', 'grades')
-               . ': ' . $options[$CFG->grade_report_aggregationview] . ')';
-        $mform->addElement('select', 'pref_aggregationview', $label, $options);
-        $mform->setHelpButton('pref_aggregationview', array('aggregationview', get_string('aggregationview', 'grades'), 'grade'), true);
-        $mform->setDefault('pref_aggregationview', GRADE_REPORT_PREFERENCE_DEFAULT);
-        $mform->setAdvanced('pref_aggregationview');
-
         // hidden params
         $mform->addElement('hidden', 'id', 0);
         $mform->setType('id', PARAM_INT);