L-electron-Rare/mlx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix assigning bool to float16/bfloat16 (#3229)

Browse Source 
Co-authored-by: KD2YCU <me@kd2ycu.com>
Co-authored-by: Angelos Katharopoulos <a_katharopoulos@apple.com>
This commit is contained in:
Dan Anderson
2026-03-10 00:50:05 -04:00
committed by GitHub
parent 572e0a4ac3
commit 6ac5280db4
3 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/array_tests.cpp
+10
View File
@@ -105,6 +105,16 @@ TEST_CASE("test array basics") {
CHECK_EQ(x.dtype(), bool_);
CHECK(array_equal(x, array({false, true, false, true})).item<bool>());
}
// Regression: vector<bool>::reference to fp16/bf16 stored raw bits
{
std::vector<bool> data = {true, false, true};
auto bf = array(data.begin(), {3}, bfloat16);
CHECK(array_equal(bf, array({1.0f, 0.0f, 1.0f}, bfloat16)).item<bool>());
auto fp = array(data.begin(), {3}, float16);
CHECK(array_equal(fp, array({1.0f, 0.0f, 1.0f}, float16)).item<bool>());
}
}
TEST_CASE("test array types") {